cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Simplify element show paths in api tests

Browse source
This commit is contained in:
Anton Khorev 2024-04-02 14:53:17 +03:00
parent 352e5de4b9
commit ba2eb52054
5 changed files with 35 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

12
test/controllers/api/nodes_controller_test.rb
View file

@ -151,7 +151,7 @@ module Api
assert_response :gone
# check chat a non-existent node is not returned
get api_node_path(:id => 0)
get api_node_path(0)
assert_response :not_found
end
@ -201,7 +201,7 @@ module Api
assert_require_public_data
# this won't work since the node never existed
delete api_node_path(:id => 0), :headers => auth_header
delete api_node_path(0), :headers => auth_header
assert_require_public_data
## these test whether nodes which are in-use can be deleted:
@ -241,7 +241,7 @@ module Api
# try to delete a node with a different ID
other_node = create(:node)
xml = xml_for_node(other_node)
delete api_node_path(node.id), :params => xml.to_s, :headers => auth_header
delete api_node_path(node), :params => xml.to_s, :headers => auth_header
assert_response :bad_request,
"should not be able to delete a node with a different ID from the XML"
@ -266,7 +266,7 @@ module Api
assert_response :gone
# this won't work since the node never existed
delete api_node_path(:id => 0), :headers => auth_header
delete api_node_path(0), :headers => auth_header
assert_response :not_found
## these test whether nodes which are in-use can be deleted:
@ -360,7 +360,7 @@ module Api
# try and update a node without authorisation
# first try to update node without auth
xml = xml_for_node(node)
put api_node_path(node.id), :params => xml.to_s, :headers => auth_header
put api_node_path(node), :params => xml.to_s, :headers => auth_header
assert_response :forbidden
# setup auth
@ -548,7 +548,7 @@ module Api
assert_not_nil checknode, "node not found in data base after upload"
# and grab it using the api
get api_node_path(:id => nodeid)
get api_node_path(nodeid)
assert_response :success
apinode = Node.from_xml(@response.body)
assert_not_nil apinode, "downloaded node is nil, but shouldn't be"