Use with_settings for temporary changes to settings

This commit is contained in:
Tom Hughes 2024-02-01 18:37:28 +00:00
parent e83f0bd131
commit b9c5df4dad
4 changed files with 17 additions and 43 deletions

View file

@ -235,22 +235,19 @@ class RelationTest < ActiveSupport::TestCase
# the maximum number of members in a relation.
def test_max_members_per_relation_limit
# Speed up unit test by using a small relation member limit
default_limit = Settings.max_number_of_relation_members
Settings.max_number_of_relation_members = 20
with_settings(:max_number_of_relation_members => 20) do
user = create(:user)
changeset = create(:changeset, :user => user)
relation = create(:relation, :changeset => changeset)
node = create(:node, :longitude => 116, :latitude => 39)
# Create relation which exceeds the relation member limit by one
0.upto(Settings.max_number_of_relation_members) do |i|
create(:relation_member, :relation => relation, :member_type => "Node", :member_id => node.id, :sequence_id => i)
end
user = create(:user)
changeset = create(:changeset, :user => user)
relation = create(:relation, :changeset => changeset)
node = create(:node, :longitude => 116, :latitude => 39)
# Create relation which exceeds the relation member limit by one
0.upto(Settings.max_number_of_relation_members) do |i|
create(:relation_member, :relation => relation, :member_type => "Node", :member_id => node.id, :sequence_id => i)
assert_raise OSM::APITooManyRelationMembersError do
relation.create_with_history user
end
end
assert_raise OSM::APITooManyRelationMembersError do
relation.create_with_history user
end
Settings.max_number_of_relation_members = default_limit
end
end