cover the other extreme in the map bounary sanitizeation. Ading some documentation, which is parsed when running rake doc:app. Fixing up a couple of tests.
This commit is contained in:
parent
dc2a959037
commit
b45dd63283
5 changed files with 61 additions and 24 deletions
|
@ -12,13 +12,15 @@ class ApiControllerTest < Test::Unit::TestCase
|
|||
@request = ActionController::TestRequest.new
|
||||
@response = ActionController::TestResponse.new
|
||||
@badbigbbox = %w{ -0.1,-0.1,1.1,1.1 10,10,11,11 }
|
||||
@badmalformedbbox = %w{ -0.1 hello S0.1,W0.1,N0.1,E0.1
|
||||
@badmalformedbbox = %w{ -0.1 hello
|
||||
10N2W10.1N2.1W }
|
||||
@badlatmixedbbox = %w{ 0,0.1,0.1,0 -0.1,80,0.1,70 0.24,54.34,0.25,54.33 }
|
||||
@badlonmixedbbox = %w{ 80,-0.1,70,0.1 54.34,0.24,54.33,0.25 }
|
||||
@badlatlonoutboundsbbox = %w{ 191,-0.1,193,0.1 -190.1,89.9,-190,90 }
|
||||
#@badlatlonoutboundsbbox = %w{ 191,-0.1,193,0.1 -190.1,89.9,-190,90 }
|
||||
@goodbbox = %w{ -0.1,-0.1,0.1,0.1 51.1,-0.1,51.2,0
|
||||
-0.1,%20-0.1,%200.1,%200.1 -0.1edcd,-0.1d,0.1,0.1 -0.1E,-0.1E,0.1S,0.1N }
|
||||
-0.1,%20-0.1,%200.1,%200.1 -0.1edcd,-0.1d,0.1,0.1 -0.1E,-0.1E,0.1S,0.1N S0.1,W0.1,N0.1,E0.1}
|
||||
# That last item in the goodbbox really shouldn't be there, as the API should
|
||||
# reall reject it, however this is to test to see if the api changes.
|
||||
end
|
||||
|
||||
def basic_authorization(user, pass)
|
||||
|
@ -114,16 +116,17 @@ class ApiControllerTest < Test::Unit::TestCase
|
|||
end
|
||||
end
|
||||
|
||||
def test_latlon_outofbounds
|
||||
@badlatlonoutboundsbbox.each do |bbox|
|
||||
[ "trackpoints", "map" ].each do |tq|
|
||||
get tq, :bbox => bbox
|
||||
#print @request.to_yaml
|
||||
assert_response :bad_request, "The bbox #{bbox} was expected to be out of range"
|
||||
assert_equal "The latitudes must be between -90 an 90, and longitudes between -180 and 180", @response.body, "bbox: #{bbox}"
|
||||
end
|
||||
end
|
||||
end
|
||||
# We can't actually get an out of bounds error, as the bbox is sanitised.
|
||||
#def test_latlon_outofbounds
|
||||
# @badlatlonoutboundsbbox.each do |bbox|
|
||||
# [ "trackpoints", "map" ].each do |tq|
|
||||
# get tq, :bbox => bbox
|
||||
# #print @request.to_yaml
|
||||
# assert_response :bad_request, "The bbox #{bbox} was expected to be out of range"
|
||||
# assert_equal "The latitudes must be between -90 an 90, and longitudes between -180 and 180", @response.body, "bbox: #{bbox}"
|
||||
# end
|
||||
# end
|
||||
#end
|
||||
|
||||
def test_capabilities
|
||||
get :capabilities
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue