cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Arrange button sizes to default size of 36px

Browse source 
As discussed in #4773 there was not any clarification as why auth button sizes were reduced so 36px is now accepted as default. This commit addresses that comment/issue.
This commit is contained in:
Emin Kocan 2024-06-20 21:18:32 +02:00
parent 5aa4d49281
commit b057c7ae5a
3 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
app/helpers/user_helper.rb
View file

@ -53,7 +53,7 @@ module UserHelper
# External authentication support # External authentication support
def openid_logo def openid_logo
image_tag "openid.svg", :size => "24", :alt => t("application.auth_providers.openid_logo_alt"), :class => "align-text-bottom" image_tag "openid.svg", :size => "36", :alt => t("application.auth_providers.openid_logo_alt"), :class => "align-text-bottom"
end end
def auth_button(name, provider, options = {}) def auth_button(name, provider, options = {})
@ -61,7 +61,7 @@ module UserHelper
image_tag("#{name}.svg", image_tag("#{name}.svg",
:alt => t("application.auth_providers.#{name}.alt"), :alt => t("application.auth_providers.#{name}.alt"),
:class => "rounded-1", :class => "rounded-1",
:size => "24"), :size => "36"),
auth_path(options.merge(:provider => provider)), auth_path(options.merge(:provider => provider)),
:method => :post, :method => :post,
:class => "auth_button p-2 d-block", :class => "auth_button p-2 d-block",
@ -74,7 +74,7 @@ module UserHelper
image_tag("#{name}.svg", image_tag("#{name}.svg",
:alt => t("application.auth_providers.#{name}.alt"), :alt => t("application.auth_providers.#{name}.alt"),
:class => "rounded-1 me-3", :class => "rounded-1 me-3",
:size => "24") + t("application.auth_providers.#{name}.title"), :size => "36") + t("application.auth_providers.#{name}.title"),
auth_path(options.merge(:provider => provider)), auth_path(options.merge(:provider => provider)),
:method => :post, :method => :post,
:class => "auth_button fs-6 border rounded text-body-secondary text-decoration-none py-2 px-4 d-flex justify-content-center align-items-center", :class => "auth_button fs-6 border rounded text-body-secondary text-decoration-none py-2 px-4 d-flex justify-content-center align-items-center",

2
app/views/application/_auth_providers.html.erb
View file

@ -27,7 +27,7 @@
<%= link_to image_tag("openid.png", <%= link_to image_tag("openid.png",
:alt => t("application.auth_providers.openid.title"), :alt => t("application.auth_providers.openid.title"),
:size => "24"), :size => "36"),
"#", "#",
:id => "openid_open_url", :id => "openid_open_url",
:title => t("application.auth_providers.openid.title"), :title => t("application.auth_providers.openid.title"),

2
test/helpers/user_helper_test.rb
View file

@ -116,7 +116,7 @@ class UserHelperTest < ActionView::TestCase
def test_auth_button def test_auth_button
button = auth_button("google", "google") button = auth_button("google", "google")
img_tag = "<img alt=\"Log in with a Google OpenID\" class=\"rounded-1\" src=\"/images/google.svg\" width=\"24\" height=\"24\" />" img_tag = "<img alt=\"Log in with a Google OpenID\" class=\"rounded-1\" src=\"/images/google.svg\" width=\"36\" height=\"36\" />"
assert_equal("<a class=\"auth_button p-2 d-block\" title=\"Log in with Google\" rel=\"nofollow\" data-method=\"post\" href=\"/auth/google\">#{img_tag}</a>", button) assert_equal("<a class=\"auth_button p-2 d-block\" title=\"Log in with Google\" rel=\"nofollow\" data-method=\"post\" href=\"/auth/google\">#{img_tag}</a>", button)
end end