Drop monkey patch now we're using option style redirects

Option style redirects escape path parameters correctly, so we
can drop out monkey patch.
This commit is contained in:
Tom Hughes 2013-12-01 20:54:52 +00:00
parent 248d0b863c
commit aff0583a34
2 changed files with 8 additions and 16 deletions

View file

@ -1,16 +0,0 @@
require "action_dispatch/routing/redirection"
#
# Fix escaping in routes to use path style escaping
#
# https://github.com/rails/rails/issues/13110
#
module ActionDispatch
module Routing
class PathRedirect < Redirect
def escape(params)
Hash[params.map{ |k,v| [k, URI.escape(v)] }]
end
end
end
end

View file

@ -31,6 +31,10 @@ class RedirectTest < ActionDispatch::IntegrationTest
get "/user/name/edits"
assert_response :redirect
assert_redirected_to "/user/name/history"
get "/user/name%20with%20spaces/edits"
assert_response :redirect
assert_redirected_to "/user/name%20with%20spaces/history"
end
def test_history_feed_redirects
@ -45,6 +49,10 @@ class RedirectTest < ActionDispatch::IntegrationTest
get "/user/name/edits/feed"
assert_response :redirect
assert_redirected_to "/user/name/history/feed"
get "/user/name%20with%20spaces/edits/feed"
assert_response :redirect
assert_redirected_to "/user/name%20with%20spaces/history/feed"
end
def test_browse_redirects