cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #4587 from AntonKhorev/changeset-comment-routes

Browse source 
Move changeset comments feed to resourceful routes
This commit is contained in:
Andy Allan 2024-08-28 18:30:11 +01:00 • committed by GitHub
commit a948f2bc24
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
11 changed files with 144 additions and 134 deletions
Download patch file Download diff file Expand all files Collapse all files

70
test/controllers/changeset_comments_controller_test.rb
View file

@ -1,70 +0,0 @@
require "test_helper"
class ChangesetCommentsControllerTest < ActionDispatch::IntegrationTest
##
# test all routes which lead to this controller
def test_routes
assert_routing(
{ :path => "/changeset/1/comments/feed", :method => :get },
{ :controller => "changeset_comments", :action => "index", :id => "1", :format => "rss" }
)
assert_routing(
{ :path => "/history/comments/feed", :method => :get },
{ :controller => "changeset_comments", :action => "index", :format => "rss" }
)
end
##
# test comments feed
def test_feed
changeset = create(:changeset, :closed)
create_list(:changeset_comment, 3, :changeset => changeset)
get changesets_comments_feed_path(:format => "rss")
assert_response :success
assert_equal "application/rss+xml", @response.media_type
assert_select "rss", :count => 1 do
assert_select "channel", :count => 1 do
assert_select "item", :count => 3
end
end
get changesets_comments_feed_path(:format => "rss", :limit => 2)
assert_response :success
assert_equal "application/rss+xml", @response.media_type
assert_select "rss", :count => 1 do
assert_select "channel", :count => 1 do
assert_select "item", :count => 2
end
end
get changeset_comments_feed_path(:id => changeset.id, :format => "rss")
assert_response :success
assert_equal "application/rss+xml", @response.media_type
last_comment_id = -1
assert_select "rss", :count => 1 do
assert_select "channel", :count => 1 do
assert_select "item", :count => 3 do |items|
items.each do |item|
assert_select item, "link", :count => 1 do |link|
match = assert_match(/^#{changeset_url changeset}#c(\d+)$/, link.text)
comment_id = match[1].to_i
assert_operator comment_id, "<", last_comment_id if last_comment_id != -1
last_comment_id = comment_id
end
end
end
end
end
end
##
# test comments feed
def test_feed_bad_limit
get changesets_comments_feed_path(:format => "rss", :limit => 0)
assert_response :bad_request
get changesets_comments_feed_path(:format => "rss", :limit => 100001)
assert_response :bad_request
end
end

72
test/controllers/feeds/changeset_comments_controller_test.rb Normal file
View file

@ -0,0 +1,72 @@
require "test_helper"
module Feeds
class ChangesetCommentsControllerTest < ActionDispatch::IntegrationTest
##
# test all routes which lead to this controller
def test_routes
assert_routing(
{ :path => "/changeset/1/comments/feed", :method => :get },
{ :controller => "feeds/changeset_comments", :action => "index", :changeset_id => "1", :format => "rss" }
)
assert_routing(
{ :path => "/history/comments/feed", :method => :get },
{ :controller => "feeds/changeset_comments", :action => "index", :format => "rss" }
)
end
##
# test comments feed
def test_feed
changeset = create(:changeset, :closed)
create_list(:changeset_comment, 3, :changeset => changeset)
get feeds_changeset_comments_path(:format => "rss")
assert_response :success
assert_equal "application/rss+xml", @response.media_type
assert_select "rss", :count => 1 do
assert_select "channel", :count => 1 do
assert_select "item", :count => 3
end
end
get feeds_changeset_comments_path(:format => "rss", :limit => 2)
assert_response :success
assert_equal "application/rss+xml", @response.media_type
assert_select "rss", :count => 1 do
assert_select "channel", :count => 1 do
assert_select "item", :count => 2
end
end
get changeset_feeds_changeset_comments_path(changeset, :format => "rss")
assert_response :success
assert_equal "application/rss+xml", @response.media_type
last_comment_id = -1
assert_select "rss", :count => 1 do
assert_select "channel", :count => 1 do
assert_select "item", :count => 3 do |items|
items.each do |item|
assert_select item, "link", :count => 1 do |link|
match = assert_match(/^#{changeset_url changeset}#c(\d+)$/, link.text)
comment_id = match[1].to_i
assert_operator comment_id, "<", last_comment_id if last_comment_id != -1
last_comment_id = comment_id
end
end
end
end
end
end
##
# test comments feed
def test_feed_bad_limit
get feeds_changeset_comments_path(:format => "rss", :limit => 0)
assert_response :bad_request
get feeds_changeset_comments_path(:format => "rss", :limit => 100001)
assert_response :bad_request
end
end
end