Fix more rubocop style issues

This commit is contained in:
Tom Hughes 2015-02-24 20:45:55 +00:00
parent 16da03aacb
commit a6b84a0294
24 changed files with 50 additions and 77 deletions

View file

@ -141,7 +141,7 @@ class Node < ActiveRecord::Base
# update changeset bbox with *old* position first
changeset.update_bbox!(bbox)
# FIXME logic needs to be double checked
# FIXME: logic needs to be double checked
self.latitude = new_node.latitude
self.longitude = new_node.longitude
self.tags = new_node.tags

View file

@ -70,7 +70,7 @@ class OldWay < ActiveRecord::Base
add_metadata_to_xml_node(el, self, changeset_cache, user_display_name_cache)
old_nodes.each do |nd| # FIXME need to make sure they come back in the right order
old_nodes.each do |nd| # FIXME: need to make sure they come back in the right order
node_el = XML::Node.new "nd"
node_el["ref"] = nd.node_id.to_s
el << node_el

View file

@ -135,7 +135,7 @@ class Relation < ActiveRecord::Base
el
end
# FIXME is this really needed?
# FIXME: is this really needed?
def members
@members ||= relation_members.map do |member|
[member.member_type, member.member_id, member.member_role]

View file

@ -219,7 +219,7 @@ class Trace < ActiveRecord::Base
end
def xml_file
# TODO *nix specific, could do to work on windows... would be functionally inferior though - check for '.gz'
# TODO: *nix specific, could do to work on windows... would be functionally inferior though - check for '.gz'
filetype = `/usr/bin/file -bz #{trace_name}`.chomp
gzipped = filetype =~ /gzip compressed/
bzipped = filetype =~ /bzip2 compressed/