cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove inline javascript from login page

Browse source
This commit is contained in:
Tom Hughes 2015-12-12 11:42:36 +00:00
parent 8c38faa90e
commit 9dd5dabf86
2 changed files with 23 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

18
app/assets/javascripts/login.js Normal file
View file

@ -0,0 +1,18 @@
$(document).ready(function() {
// Preserve location hash in referer
if (window.location.hash) {
$("#referer").val($("#referer").val() + window.location.hash);
}
// Add click handler to show OpenID field
$("#openid_open_url").click(function() {
$("#openid_url").val("http://");
$("#login_auth_buttons").hide();
$("#login_openid_url").show();
$("#login_openid_submit").show();
});
// Hide OpenID field for now
$("#login_openid_url").hide();
$("#login_openid_submit").hide();
});

25
app/views/user/login.html.erb
View file

@ -1,8 +1,12 @@
<div id="login_login">
<% content_for :head do %>
<%= javascript_include_tag "login" %>
<% end %>
<% content_for :heading do %>
<h1><%= t 'user.login.heading' %></h1>
<% end %>
<div id="login_login">
<%= form_tag({ :action => "login" }, { :id => "login_form" }) do %>
<%= hidden_field_tag('referer', h(params[:referer])) %>
@ -76,22 +80,3 @@
<% end %>
</div>
<script type="text/javascript">
$(document).ready(function() {
// Preserve location hash in referer
if (window.location.hash) {
$('#referer').val($('#referer').val() + window.location.hash);
}
$("#openid_open_url").click(function() {
$("#openid_url").val("http://");
$("#login_auth_buttons").hide();
$("#login_openid_url").show();
$("#login_openid_submit").show();
});
$("#login_openid_url").hide();
$("#login_openid_submit").hide();
});
</script>