cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use simple string matches for user_blocks_helper tests

Browse source 
Testing against the translations is not something we do anywhere
else is and is dangerously close to testing the helper against
itself which is a bit pointless.
This commit is contained in:
Tom Hughes 2017-02-19 11:50:01 +00:00
parent 9c926c6c71
commit 9b52542e52
1 changed files with 5 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

12
test/helpers/user_blocks_helper_test.rb
View file

@ -5,14 +5,12 @@ class UserBlocksHelperTest < ActionView::TestCase
def test_block_status
block = create(:user_block, :needs_view, :ends_at => Time.now.getutc)
assert_equal I18n.t("user_block.helper.until_login"), block_status(block)
assert_equal "Active until the user logs in.", block_status(block)
block_end = Time.now.getutc + 60.minutes
block = create(:user_block, :needs_view, :ends_at => block_end)
assert_equal I18n.t("user_block.helper.time_future_and_until_login", :time => friendly_date(block_end)), block_status(block)
block = create(:user_block, :needs_view, :ends_at => Time.now.getutc + 1.hour)
assert_match %r{^Ends in <span title=".*">about 1 hour</span> and after the user has logged in\.$}, block_status(block)
block_end = Time.now.getutc + 60.minutes
block = create(:user_block, :ends_at => block_end)
assert_equal I18n.t("user_block.helper.time_future", :time => friendly_date(block_end)), block_status(block)
block = create(:user_block, :ends_at => Time.now.getutc + 1.hour)
assert_match %r{^Ends in <span title=".*">about 1 hour</span>\.$}, block_status(block)
end
end