Refactor permissions_controller_test

This commit is contained in:
Tom Hughes 2020-05-05 19:40:52 +01:00
parent c576edecd4
commit 9a87412d2a

View file

@ -1,7 +1,7 @@
require "test_helper" require "test_helper"
module Api module Api
class PermissionsControllerTest < ActionController::TestCase class PermissionsControllerTest < ActionDispatch::IntegrationTest
## ##
# test all routes which lead to this controller # test all routes which lead to this controller
def test_routes def test_routes
@ -12,7 +12,7 @@ module Api
end end
def test_permissions_anonymous def test_permissions_anonymous
get :show get permissions_path
assert_response :success assert_response :success
assert_select "osm > permissions", :count => 1 do assert_select "osm > permissions", :count => 1 do
assert_select "permission", :count => 0 assert_select "permission", :count => 0
@ -20,8 +20,8 @@ module Api
end end
def test_permissions_basic_auth def test_permissions_basic_auth
basic_authorization create(:user).email, "test" auth_header = basic_authorization_header create(:user).email, "test"
get :show get permissions_path, :headers => auth_header
assert_response :success assert_response :success
assert_select "osm > permissions", :count => 1 do assert_select "osm > permissions", :count => 1 do
assert_select "permission", :count => ClientApplication.all_permissions.size assert_select "permission", :count => ClientApplication.all_permissions.size
@ -32,13 +32,11 @@ module Api
end end
def test_permissions_oauth def test_permissions_oauth
@request.env["oauth.token"] = AccessToken.new do |token| token = create(:access_token,
# Just to test a few :allow_read_prefs => true,
token.allow_read_prefs = true :allow_write_api => true,
token.allow_write_api = true :allow_read_gpx => false)
token.allow_read_gpx = false signed_get permissions_path, :oauth => { :token => token }
end
get :show
assert_response :success assert_response :success
assert_select "osm > permissions", :count => 1 do assert_select "osm > permissions", :count => 1 do
assert_select "permission", :count => 2 assert_select "permission", :count => 2