cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Test api old element show accessed as moderator

Browse source
This commit is contained in:
Anton Khorev 2025-02-09 18:50:48 +03:00
parent 1b977454f7
commit 98a365c827
3 changed files with 42 additions and 77 deletions
Download patch file Download diff file Expand all files Collapse all files

39
test/controllers/api/old_nodes_controller_test.rb
View file

@ -170,6 +170,20 @@ module Api
assert_response :forbidden, "Redacted node shouldn't be visible via the version API, even when logged in and passing flag."
end
def test_show_redacted_moderator
node = create(:node, :with_history, :version => 2)
node.old_nodes.find_by(:version => 1).redact!(create(:redaction))
auth_header = bearer_authorization_header create(:moderator_user)
get api_node_version_path(node, 1), :headers => auth_header
assert_response :forbidden, "Redacted node should be gone for moderator, when flag not passed."
get api_node_version_path(node, 1, :show_redactions => "true"), :headers => auth_header
assert_response :success, "Redacted node should not be gone for moderator, when flag passed."
end
# Ensure the lat/lon is formatted as a decimal e.g. not 4.0e-05
def test_lat_lon_xml_format
old_node = create(:old_node, :latitude => (0.00004 * OldNode::SCALE).to_i, :longitude => (0.00008 * OldNode::SCALE).to_i)
@ -257,31 +271,6 @@ module Api
assert_response :success, "should be OK to redact old version as moderator."
assert_predicate node_v3.reload, :redacted?
# check moderator can still see the redacted data, when passing
# the appropriate flag
get api_node_version_path(node_v3.node_id, node_v3.version), :headers => auth_header
assert_response :forbidden, "After redaction, node should be gone for moderator, when flag not passed."
get api_node_version_path(node_v3.node_id, node_v3.version, :show_redactions => "true"), :headers => auth_header
assert_response :success, "After redaction, node should not be gone for moderator, when flag passed."
end
# testing that if the moderator drops auth, he can't see the
# redacted stuff any more.
def test_redact_node_is_redacted
node = create(:node, :with_history, :version => 4)
node_v3 = node.old_nodes.find_by(:version => 3)
auth_header = bearer_authorization_header create(:moderator_user)
do_redact_node(node_v3, create(:redaction), auth_header)
assert_response :success, "should be OK to redact old version as moderator."
# re-auth as non-moderator
auth_header = bearer_authorization_header
# check can't see the redacted data
get api_node_version_path(node_v3.node_id, node_v3.version), :headers => auth_header
assert_response :forbidden, "Redacted node shouldn't be visible via the version API."
end
##

41
test/controllers/api/old_relations_controller_test.rb
View file

@ -170,6 +170,20 @@ module Api
assert_response :forbidden, "Redacted relation shouldn't be visible via the version API, even when logged in and passing flag."
end
def test_show_redacted_moderator
relation = create(:relation, :with_history, :version => 2)
relation.old_relations.find_by(:version => 1).redact!(create(:redaction))
auth_header = bearer_authorization_header create(:moderator_user)
get api_relation_version_path(relation, 1), :headers => auth_header
assert_response :forbidden, "Redacted relation should be gone for moderator, when flag not passed."
get api_relation_version_path(relation, 1, :show_redactions => "true"), :headers => auth_header
assert_response :success, "Redacted relation should not be gone for moderator, when flag passed."
end
##
# test the redaction of an old version of a relation, while not being
# authorised.
@ -237,39 +251,12 @@ module Api
def test_redact_relation_moderator
relation = create(:relation, :with_history, :version => 4)
relation_v3 = relation.old_relations.find_by(:version => 3)
auth_header = bearer_authorization_header create(:moderator_user)
do_redact_relation(relation_v3, create(:redaction), auth_header)
assert_response :success, "should be OK to redact old version as moderator."
assert_predicate relation_v3.reload, :redacted?
# check moderator can still see the redacted data, when passing
# the appropriate flag
get api_relation_version_path(relation_v3.relation_id, relation_v3.version), :headers => auth_header
assert_response :forbidden, "After redaction, relation should be gone for moderator, when flag not passed."
get api_relation_version_path(relation_v3.relation_id, relation_v3.version, :show_redactions => "true"), :headers => auth_header
assert_response :success, "After redaction, relation should not be gone for moderator, when flag passed."
end
# testing that if the moderator drops auth, he can't see the
# redacted stuff any more.
def test_redact_relation_is_redacted
relation = create(:relation, :with_history, :version => 4)
relation_v3 = relation.old_relations.find_by(:version => 3)
auth_header = bearer_authorization_header create(:moderator_user)
do_redact_relation(relation_v3, create(:redaction), auth_header)
assert_response :success, "should be OK to redact old version as moderator."
# re-auth as non-moderator
auth_header = bearer_authorization_header
# check can't see the redacted data
get api_relation_version_path(relation_v3.relation_id, relation_v3.version), :headers => auth_header
assert_response :forbidden, "Redacted relation shouldn't be visible via the version API."
end
##

39
test/controllers/api/old_ways_controller_test.rb
View file

@ -167,6 +167,20 @@ module Api
assert_response :forbidden, "Redacted way shouldn't be visible via the version API, even when logged in and passing flag."
end
def test_show_redacted_moderator
way = create(:way, :with_history, :version => 2)
way.old_ways.find_by(:version => 1).redact!(create(:redaction))
auth_header = bearer_authorization_header create(:moderator_user)
get api_way_version_path(way, 1), :headers => auth_header
assert_response :forbidden, "Redacted node should be gone for moderator, when flag not passed."
get api_way_version_path(way, 1, :show_redactions => "true"), :headers => auth_header
assert_response :success, "Redacted node should not be gone for moderator, when flag passed."
end
##
# check that returned history is the same as getting all
# versions of a way from the api.
@ -252,31 +266,6 @@ module Api
assert_response :success, "should be OK to redact old version as moderator."
assert_predicate way_v3.reload, :redacted?
# check moderator can still see the redacted data, when passing
# the appropriate flag
get api_way_version_path(way_v3.way_id, way_v3.version), :headers => auth_header
assert_response :forbidden, "After redaction, node should be gone for moderator, when flag not passed."
get api_way_version_path(way_v3.way_id, way_v3.version, :show_redactions => "true"), :headers => auth_header
assert_response :success, "After redaction, node should not be gone for moderator, when flag passed."
end
# testing that if the moderator drops auth, he can't see the
# redacted stuff any more.
def test_redact_way_is_redacted
way = create(:way, :with_history, :version => 4)
way_v3 = way.old_ways.find_by(:version => 3)
auth_header = bearer_authorization_header create(:moderator_user)
do_redact_way(way_v3, create(:redaction), auth_header)
assert_response :success, "should be OK to redact old version as moderator."
# re-auth as non-moderator
auth_header = bearer_authorization_header
# check can't see the redacted data
get api_way_version_path(way_v3.way_id, way_v3.version), :headers => auth_header
assert_response :forbidden, "Redacted node shouldn't be visible via the version API."
end
##