cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Create node version redaction resource

Browse source
This commit is contained in:
Anton Khorev 2025-02-11 04:33:27 +03:00
parent 84c4ed3fa8
commit 984dd624dd
5 changed files with 187 additions and 131 deletions
Download patch file Download diff file Expand all files Collapse all files

127
test/controllers/api/old_nodes_controller_test.rb
View file

@ -21,10 +21,6 @@ module Api
{ :path => "/api/0.6/node/1/2.json", :method => :get },
{ :controller => "api/old_nodes", :action => "show", :node_id => "1", :version => "2", :format => "json" }
)
assert_routing(
{ :path => "/api/0.6/node/1/2/redact", :method => :post },
{ :controller => "api/old_nodes", :action => "redact", :node_id => "1", :version => "2" }
)
end
def test_index
@ -193,129 +189,6 @@ module Api
assert_match(/lon="0.0000800"/, response.body)
end
##
# test that, even as moderator, the current version of a node
# can't be redacted.
def test_redact_node_current_version
node = create(:node, :with_history, :version => 2)
old_node = node.old_nodes.find_by(:version => 2)
redaction = create(:redaction)
auth_header = bearer_authorization_header create(:moderator_user)
post node_version_redact_path(*old_node.id), :params => { :redaction => redaction.id }, :headers => auth_header
assert_response :bad_request, "shouldn't be OK to redact current version as moderator."
assert_nil old_node.reload.redaction
end
##
# test the redaction of an old version of a node, while not being
# authorised.
def test_redact_node_unauthorised
node = create(:node, :with_history, :version => 2)
old_node = node.old_nodes.find_by(:version => 1)
redaction = create(:redaction)
post node_version_redact_path(*old_node.id), :params => { :redaction => redaction.id }
assert_response :unauthorized, "should need to be authenticated to redact."
assert_nil old_node.reload.redaction
end
def test_redact_node_by_regular_without_write_redactions_scope
node = create(:node, :with_history, :version => 2)
old_node = node.old_nodes.find_by(:version => 1)
redaction = create(:redaction)
auth_header = bearer_authorization_header(create(:user), :scopes => %w[read_prefs write_api])
post node_version_redact_path(*old_node.id), :params => { :redaction => redaction.id }, :headers => auth_header
assert_response :forbidden, "should need to be moderator to redact."
assert_nil old_node.reload.redaction
end
def test_redact_node_by_regular_with_write_redactions_scope
node = create(:node, :with_history, :version => 2)
old_node = node.old_nodes.find_by(:version => 1)
redaction = create(:redaction)
auth_header = bearer_authorization_header(create(:user), :scopes => %w[write_redactions])
post node_version_redact_path(*old_node.id), :params => { :redaction => redaction.id }, :headers => auth_header
assert_response :forbidden, "should need to be moderator to redact."
assert_nil old_node.reload.redaction
end
def test_redact_node_by_moderator_without_write_redactions_scope
node = create(:node, :with_history, :version => 2)
old_node = node.old_nodes.find_by(:version => 1)
redaction = create(:redaction)
auth_header = bearer_authorization_header(create(:moderator_user), :scopes => %w[read_prefs write_api])
post node_version_redact_path(*old_node.id), :params => { :redaction => redaction.id }, :headers => auth_header
assert_response :forbidden, "should need to have write_redactions scope to redact."
assert_nil old_node.reload.redaction
end
def test_redact_node_by_moderator_with_write_redactions_scope
node = create(:node, :with_history, :version => 2)
old_node = node.old_nodes.find_by(:version => 1)
redaction = create(:redaction)
auth_header = bearer_authorization_header(create(:moderator_user), :scopes => %w[write_redactions])
post node_version_redact_path(*old_node.id), :params => { :redaction => redaction.id }, :headers => auth_header
assert_response :success, "should be OK to redact old version as moderator with write_redactions scope."
assert_equal redaction, old_node.reload.redaction
end
##
# test the unredaction of an old version of a node, while not being
# authorised.
def test_unredact_node_unauthorised
node = create(:node, :with_history, :version => 2)
old_node = node.old_nodes.find_by(:version => 1)
redaction = create(:redaction)
old_node.redact!(redaction)
post node_version_redact_path(*old_node.id)
assert_response :unauthorized, "should need to be authenticated to unredact."
assert_equal redaction, old_node.reload.redaction
end
##
# test the unredaction of an old version of a node, while being
# authorised as a normal user.
def test_unredact_node_normal_user
node = create(:node, :with_history, :version => 2)
old_node = node.old_nodes.find_by(:version => 1)
redaction = create(:redaction)
old_node.redact!(redaction)
auth_header = bearer_authorization_header
post node_version_redact_path(*old_node.id), :headers => auth_header
assert_response :forbidden, "should need to be moderator to unredact."
assert_equal redaction, old_node.reload.redaction
end
##
# test the unredaction of an old version of a node, while being
# authorised as a moderator.
def test_unredact_node_moderator
node = create(:node, :with_history, :version => 2)
old_node = node.old_nodes.find_by(:version => 1)
old_node.redact!(create(:redaction))
auth_header = bearer_authorization_header create(:moderator_user)
post node_version_redact_path(*old_node.id), :headers => auth_header
assert_response :success, "should be OK to unredact old version as moderator."
assert_nil old_node.reload.redaction
end
private
def check_not_found_id_version(id, version)