cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #3933 from AntonKhorev/api-changesets-limit

Browse source 
Add limit parameter to api changesets query
This commit is contained in:
Andy Allan 2023-07-26 16:45:00 +01:00 • committed by GitHub
commit 925d12cc81
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 43 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

25
test/controllers/api/changesets_controller_test.rb
View file

@ -1938,6 +1938,31 @@ module Api
assert_response :bad_request, "should be a bad request since changesets is empty"
end
##
# test the query functionality of changesets with the limit parameter
def test_query_limit
user = create(:user)
changeset1 = create(:changeset, :closed, :user => user, :created_at => Time.utc(2008, 1, 1, 0, 0, 0), :closed_at => Time.utc(2008, 1, 2, 0, 0, 0))
changeset2 = create(:changeset, :closed, :user => user, :created_at => Time.utc(2008, 2, 1, 0, 0, 0), :closed_at => Time.utc(2008, 2, 2, 0, 0, 0))
changeset3 = create(:changeset, :closed, :user => user, :created_at => Time.utc(2008, 3, 1, 0, 0, 0), :closed_at => Time.utc(2008, 3, 2, 0, 0, 0))
changeset4 = create(:changeset, :closed, :user => user, :created_at => Time.utc(2008, 4, 1, 0, 0, 0), :closed_at => Time.utc(2008, 4, 2, 0, 0, 0))
changeset5 = create(:changeset, :closed, :user => user, :created_at => Time.utc(2008, 5, 1, 0, 0, 0), :closed_at => Time.utc(2008, 5, 2, 0, 0, 0))
get changesets_path
assert_response :success
assert_changesets [changeset5, changeset4, changeset3, changeset2, changeset1]
get changesets_path(:limit => "3")
assert_response :success
assert_changesets [changeset5, changeset4, changeset3]
get changesets_path(:limit => "0")
assert_response :bad_request
get changesets_path(:limit => "101")
assert_response :bad_request
end
##
# check that errors are returned if garbage is inserted
# into query strings