cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Added telephone links into tag detail browser

Browse source 
International phone numbers become links using the official URI scheme
as per http://tools.ietf.org/html/rfc3966.

It is not limited to key=phone, so it can be used in other keys as well.
This commit is contained in:
Štefan Baebler 2014-06-15 09:30:17 +01:00 • committed by Tom Hughes
parent 1031af3177
commit 75e07dc5b8
3 changed files with 61 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

13
app/helpers/browse_helper.rb
View file

@ -63,6 +63,8 @@ module BrowseHelper
link_to h(wp[:title]), wp[:url], :title => t('browse.tag_details.wikipedia_link', :page => wp[:title])
elsif url = wiki_link("tag", "#{key}=#{value}")
link_to h(value), url, :title => t('browse.tag_details.wiki_link.tag', :key => key, :value => value)
elsif url = telephone_link(key, value)
link_to h(value), url, :title => t('browse.tag_details.telephone_link', :phone_number => value)
else
linkify h(value)
end
@ -146,4 +148,15 @@ private
:title => value + section
}
end
def telephone_link(key, value)
# does it look like a phone number? eg "+1 (234) 567-8901 " ?
return nil unless value =~ /^\s*\+[\d\s\(\)\/\.-]{6,25}\s*$/
# remove all whitespace instead of encoding it http://tools.ietf.org/html/rfc3966#section-5.1.1
# "+1 (234) 567-8901 " -> "+1(234)567-8901"
valueNoWhitespace = value.gsub(/\s+/, '')
return "tel:#{valueNoWhitespace}"
end
end