Fix rubocop Rake/MethodDefinitionInTask warnings

This commit is contained in:
Tom Hughes 2021-05-13 19:28:26 +01:00
parent 34bd461cbb
commit 6db5b2e6f3
2 changed files with 14 additions and 19 deletions

View file

@ -178,11 +178,6 @@ Rake/Desc:
- 'lib/tasks/subscribe_old_changesets.rake'
- 'lib/tasks/testing.rake'
# Offense count: 3
Rake/MethodDefinitionInTask:
Exclude:
- 'lib/tasks/eslint.rake'
# Offense count: 558
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.

View file

@ -1,20 +1,20 @@
task "eslint" => "eslint:check"
namespace "eslint" do
def yarn_path
def yarn_path
Rails.root.join("bin/yarn").to_s
end
end
def config_file
def config_file
Rails.root.join("config/eslint.json").to_s
end
end
def js_files
def js_files
Rails.application.assets.each_file.select do |file|
file.ends_with?(".js") && !file.match?(%r{/(gems|vendor|i18n|node_modules)/})
end
end
end
namespace "eslint" do
task :check => :environment do
system(yarn_path, "run", "eslint", "-c", config_file, *js_files) || abort
end