Add image_alt accessor to rich text
This commit is contained in:
parent
fa9654fe90
commit
69a2d5f4d4
2 changed files with 32 additions and 6 deletions
|
@ -53,6 +53,10 @@ module RichText
|
||||||
nil
|
nil
|
||||||
end
|
end
|
||||||
|
|
||||||
|
def image_alt
|
||||||
|
nil
|
||||||
|
end
|
||||||
|
|
||||||
protected
|
protected
|
||||||
|
|
||||||
def simple_format(text)
|
def simple_format(text)
|
||||||
|
@ -92,9 +96,13 @@ module RichText
|
||||||
end
|
end
|
||||||
|
|
||||||
def image
|
def image
|
||||||
return @image if defined? @image
|
@image_element = first_image_element(document.root) unless defined? @image_element
|
||||||
|
@image_element.attr["src"] if @image_element
|
||||||
|
end
|
||||||
|
|
||||||
@image = first_image_element(document.root)&.attr&.[]("src")
|
def image_alt
|
||||||
|
@image_element = first_image_element(document.root) unless defined? @image_element
|
||||||
|
@image_element.attr["alt"] if @image_element
|
||||||
end
|
end
|
||||||
|
|
||||||
private
|
private
|
||||||
|
|
|
@ -253,61 +253,79 @@ class RichTextTest < ActiveSupport::TestCase
|
||||||
def test_text_no_image
|
def test_text_no_image
|
||||||
r = RichText.new("text", "foo https://example.com/ bar")
|
r = RichText.new("text", "foo https://example.com/ bar")
|
||||||
assert_nil r.image
|
assert_nil r.image
|
||||||
|
assert_nil r.image_alt
|
||||||
end
|
end
|
||||||
|
|
||||||
def test_html_no_image
|
def test_html_no_image
|
||||||
r = RichText.new("html", "foo <a href='https://example.com/'>bar</a> baz")
|
r = RichText.new("html", "foo <a href='https://example.com/'>bar</a> baz")
|
||||||
assert_nil r.image
|
assert_nil r.image
|
||||||
|
assert_nil r.image_alt
|
||||||
end
|
end
|
||||||
|
|
||||||
def test_markdown_no_image
|
def test_markdown_no_image
|
||||||
r = RichText.new("markdown", "foo [bar](https://example.com/) baz")
|
r = RichText.new("markdown", "foo [bar](https://example.com/) baz")
|
||||||
assert_nil r.image
|
assert_nil r.image
|
||||||
|
assert_nil r.image_alt
|
||||||
end
|
end
|
||||||
|
|
||||||
def test_markdown_image
|
def test_markdown_image
|
||||||
r = RichText.new("markdown", "foo  baz")
|
r = RichText.new("markdown", "foo  baz")
|
||||||
assert_equal "https://example.com/image.jpg", r.image
|
assert_equal "https://example.com/image.jpg", r.image
|
||||||
|
assert_equal "bar", r.image_alt
|
||||||
end
|
end
|
||||||
|
|
||||||
def test_markdown_first_image
|
def test_markdown_first_image
|
||||||
r = RichText.new("markdown", "foo  baz\nfoo  baz")
|
r = RichText.new("markdown", "foo  baz\nfoo  baz")
|
||||||
assert_equal "https://example.com/image1.jpg", r.image
|
assert_equal "https://example.com/image1.jpg", r.image
|
||||||
|
assert_equal "bar1", r.image_alt
|
||||||
end
|
end
|
||||||
|
|
||||||
def test_markdown_image_with_empty_src
|
def test_markdown_image_with_empty_src
|
||||||
r = RichText.new("markdown", "![invalid]()")
|
r = RichText.new("markdown", "![invalid]()")
|
||||||
assert_nil r.image
|
assert_nil r.image
|
||||||
|
assert_nil r.image_alt
|
||||||
end
|
end
|
||||||
|
|
||||||
def test_markdown_skip_image_with_empty_src
|
def test_markdown_skip_image_with_empty_src
|
||||||
r = RichText.new("markdown", "![invalid]() ")
|
r = RichText.new("markdown", "![invalid]() ")
|
||||||
assert_equal "https://example.com/valid.gif", r.image
|
assert_equal "https://example.com/valid.gif", r.image
|
||||||
|
assert_equal "valid", r.image_alt
|
||||||
end
|
end
|
||||||
|
|
||||||
def test_markdown_html_image
|
def test_markdown_html_image
|
||||||
|
r = RichText.new("markdown", "<img src='https://example.com/img_element.png' alt='alt text here'>")
|
||||||
|
assert_equal "https://example.com/img_element.png", r.image
|
||||||
|
assert_equal "alt text here", r.image_alt
|
||||||
|
end
|
||||||
|
|
||||||
|
def test_markdown_html_image_without_alt
|
||||||
r = RichText.new("markdown", "<img src='https://example.com/img_element.png'>")
|
r = RichText.new("markdown", "<img src='https://example.com/img_element.png'>")
|
||||||
assert_equal "https://example.com/img_element.png", r.image
|
assert_equal "https://example.com/img_element.png", r.image
|
||||||
|
assert_nil r.image_alt
|
||||||
end
|
end
|
||||||
|
|
||||||
def test_markdown_html_image_with_empty_src
|
def test_markdown_html_image_with_empty_src
|
||||||
r = RichText.new("markdown", "<img src=''>")
|
r = RichText.new("markdown", "<img src='' alt='forgot src'>")
|
||||||
assert_nil r.image
|
assert_nil r.image
|
||||||
|
assert_nil r.image_alt
|
||||||
end
|
end
|
||||||
|
|
||||||
def test_markdown_skip_html_image_with_empty_src
|
def test_markdown_skip_html_image_with_empty_src
|
||||||
r = RichText.new("markdown", "<img src=''> <img src='https://example.com/next_img_element.png'>")
|
r = RichText.new("markdown", "<img src='' alt='forgot src'> <img src='https://example.com/next_img_element.png' alt='have src'>")
|
||||||
assert_equal "https://example.com/next_img_element.png", r.image
|
assert_equal "https://example.com/next_img_element.png", r.image
|
||||||
|
assert_equal "have src", r.image_alt
|
||||||
end
|
end
|
||||||
|
|
||||||
def test_markdown_html_image_without_src
|
def test_markdown_html_image_without_src
|
||||||
r = RichText.new("markdown", "<img>")
|
r = RichText.new("markdown", "<img alt='totally forgot src'>")
|
||||||
assert_nil r.image
|
assert_nil r.image
|
||||||
|
assert_nil r.image_alt
|
||||||
end
|
end
|
||||||
|
|
||||||
def test_markdown_skip_html_image_without_src
|
def test_markdown_skip_html_image_without_src
|
||||||
r = RichText.new("markdown", "<img> <img src='https://example.com/next_img_element.png'>")
|
r = RichText.new("markdown", "<img alt='totally forgot src'> <img src='https://example.com/next_img_element.png' alt='have src'>")
|
||||||
assert_equal "https://example.com/next_img_element.png", r.image
|
assert_equal "https://example.com/next_img_element.png", r.image
|
||||||
|
assert_equal "have src", r.image_alt
|
||||||
end
|
end
|
||||||
|
|
||||||
private
|
private
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue