cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Removed author_{id, ip} methods from Note model

Browse source 
Removed author_id, author_ip methods from Note model because they are not used anymore. Also, removed associated unit tests.
This commit is contained in:
Nenad Vujicic 2025-01-28 13:47:03 +01:00
parent 475a3fd836
commit 687429482f
2 changed files with 0 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

10
app/models/note.rb
View file

@ -99,16 +99,6 @@ class Note < ApplicationRecord
comments.first.author comments.first.author
end end
# Return the note's author ID, derived from the first comment
def author_id
comments.first.author_id
end
# Return the note's author IP address, derived from the first comment
def author_ip
comments.first.author_ip
end
private private
# Fill in default values for new notes # Fill in default values for new notes

17
test/models/note_test.rb
View file

@ -65,23 +65,6 @@ class NoteTest < ActiveSupport::TestCase
assert_equal user, comment.note.author assert_equal user, comment.note.author
end end
def test_author_id
comment = create(:note_comment)
assert_nil comment.note.author_id
user = create(:user)
comment = create(:note_comment, :author => user)
assert_equal user.id, comment.note.author_id
end
def test_author_ip
comment = create(:note_comment)
assert_nil comment.note.author_ip
comment = create(:note_comment, :author_ip => IPAddr.new("192.168.1.1"))
assert_equal IPAddr.new("192.168.1.1"), comment.note.author_ip
end
# Ensure the lat/lon is formatted as a decimal e.g. not 4.0e-05 # Ensure the lat/lon is formatted as a decimal e.g. not 4.0e-05
def test_lat_lon_format def test_lat_lon_format
note = build(:note, :latitude => 0.00004 * GeoRecord::SCALE, :longitude => 0.00008 * GeoRecord::SCALE) note = build(:note, :latitude => 0.00004 * GeoRecord::SCALE, :longitude => 0.00008 * GeoRecord::SCALE)