cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Replace @ with ~ in the shortlink

Browse source 
This should help Twitter's horribly broken URL detection algorithm
not screw up shortlinks from OSM.
This commit is contained in:
Matt Amos 2011-11-24 22:15:43 +00:00 • committed by Tom Hughes
parent 54a5d04782
commit 64030a40ac
4 changed files with 23 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

15
test/unit/short_link_test.rb
View file

@ -23,4 +23,19 @@ class ShortLinkTest < ActiveSupport::TestCase
assert max_distance > distance, "Maximum expected error exceeded: #{max_distance} <= #{distance} for (#{lat}, #{lon}, #{zoom})."
end
end
##
# test that links are backwards-compatible, so any old links with
# the deprecated @ characters in them still work properly.
def test_deprecated_at_sign
cases = [["~v2juONc--", "@v2juONc--"],
["as3I3GpG~-", "as3I3GpG@-"],
["D~hV--", "D@hV--"],
["CO0O~m8--", "CO0O@m8--"]]
cases.each do |new_code, old_code|
assert_equal ShortLink.decode(old_code), ShortLink.decode(new_code),
"old (#{old_code}) and new (#{new_code}) should decode to the same location."
end
end
end