Merge remote-tracking branch 'upstream/pull/5637'
This commit is contained in:
commit
62613e7b47
1 changed files with 2 additions and 2 deletions
|
@ -87,7 +87,7 @@ and why it should be the way it is.
|
||||||
|
|
||||||
## i18n
|
## i18n
|
||||||
|
|
||||||
If you make a change that involve the locale files (in `config/locales`) then please
|
If you make a change that involves the locale files (in `config/locales`) then please
|
||||||
only submit changes to the `en.yml` file. The other files are updated via
|
only submit changes to the `en.yml` file. The other files are updated via
|
||||||
[Translatewiki](https://translatewiki.net/wiki/Translating:OpenStreetMap) and should
|
[Translatewiki](https://translatewiki.net/wiki/Translating:OpenStreetMap) and should
|
||||||
not be included in your pull request.
|
not be included in your pull request.
|
||||||
|
@ -143,7 +143,7 @@ with making the reviews as straightforward as possible:
|
||||||
large to review in one sitting, or if changes are requested, then the
|
large to review in one sitting, or if changes are requested, then the
|
||||||
maintainer needs to repeatedly re-read code that has already been considered.
|
maintainer needs to repeatedly re-read code that has already been considered.
|
||||||
* The commit history is important. This is a large codebase, developed over many
|
* The commit history is important. This is a large codebase, developed over many
|
||||||
years by many developers. We frequently need to read the commit history (e.g.
|
years by many developers. We frequently need to read the commit history (for example
|
||||||
using `git blame`) to figure out what is going on. So small, understandable,
|
using `git blame`) to figure out what is going on. So small, understandable,
|
||||||
and relevant commits are important for other developers looking back at your
|
and relevant commits are important for other developers looking back at your
|
||||||
work in future.
|
work in future.
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue