cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix warnings about tests with no assertions

Browse source
This commit is contained in:
Tom Hughes 2024-09-04 19:07:00 +01:00
parent be2678e0dd
commit 60c1ae79d6
3 changed files with 28 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

4
test/helpers/application_helper_test.rb
View file

@ -88,8 +88,4 @@ class ApplicationHelperTest < ActionView::TestCase
date = friendly_date_ago(Time.now.utc - 4.months) date = friendly_date_ago(Time.now.utc - 4.months)
assert_match %r{^<time title=".*">4 months ago</time>$}, date assert_match %r{^<time title=".*">4 months ago</time>$}, date
end end
def test_body_class; end
def test_header_nav_link_class; end
end end

14
test/integration/user_creation_test.rb
View file

@ -171,13 +171,13 @@ class UserCreationTest < ActionDispatch::IntegrationTest
end end
# Check that the user can successfully recover their password # Check that the user can successfully recover their password
def test_lost_password_recovery_success # def test_lost_password_recovery_success
# Open the lost password form # Open the lost password form
# Submit the lost password form # Submit the lost password form
# Check the e-mail # Check the e-mail
# Submit the reset password token # Submit the reset password token
# Check that the password has changed, and the user can login # Check that the password has changed, and the user can login
end # end
def test_user_create_redirect def test_user_create_redirect
new_email = "redirect_tester@osm.org" new_email = "redirect_tester@osm.org"

40
test/system/history_test.rb
View file

@ -28,27 +28,29 @@ class HistoryTest < ApplicationSystemTestCase
create_visible_changeset(user, "next-changeset") create_visible_changeset(user, "next-changeset")
end end
visit "#{user_path(user)}/history" assert_nothing_raised do
changesets = find "div.changesets" visit "#{user_path(user)}/history"
changesets.assert_text "bottom-changeset-in-batch-1" changesets = find "div.changesets"
changesets.assert_no_text "bottom-changeset-in-batch-2" changesets.assert_text "bottom-changeset-in-batch-1"
changesets.assert_no_text "first-changeset-in-history" changesets.assert_no_text "bottom-changeset-in-batch-2"
changesets.assert_selector "ol", :count => 1 changesets.assert_no_text "first-changeset-in-history"
changesets.assert_selector "li", :count => PAGE_SIZE changesets.assert_selector "ol", :count => 1
changesets.assert_selector "li", :count => PAGE_SIZE
changesets.find(".changeset_more a.btn").click changesets.find(".changeset_more a.btn").click
changesets.assert_text "bottom-changeset-in-batch-1" changesets.assert_text "bottom-changeset-in-batch-1"
changesets.assert_text "bottom-changeset-in-batch-2" changesets.assert_text "bottom-changeset-in-batch-2"
changesets.assert_no_text "first-changeset-in-history" changesets.assert_no_text "first-changeset-in-history"
changesets.assert_selector "ol", :count => 1 changesets.assert_selector "ol", :count => 1
changesets.assert_selector "li", :count => 2 * PAGE_SIZE changesets.assert_selector "li", :count => 2 * PAGE_SIZE
changesets.find(".changeset_more a.btn").click changesets.find(".changeset_more a.btn").click
changesets.assert_text "bottom-changeset-in-batch-1" changesets.assert_text "bottom-changeset-in-batch-1"
changesets.assert_text "bottom-changeset-in-batch-2" changesets.assert_text "bottom-changeset-in-batch-2"
changesets.assert_text "first-changeset-in-history" changesets.assert_text "first-changeset-in-history"
changesets.assert_selector "ol", :count => 1 changesets.assert_selector "ol", :count => 1
changesets.assert_selector "li", :count => (2 * PAGE_SIZE) + 1 changesets.assert_selector "li", :count => (2 * PAGE_SIZE) + 1
end
end end
def create_visible_changeset(user, comment) def create_visible_changeset(user, comment)