Use resourceful routes for terms view/accept/decline

test/controllers/accounts/terms_controller_test.rb

@@ -0,0 +1,91 @@
+require "test_helper"
+
+module Accounts
+  class TermsControllerTest < ActionDispatch::IntegrationTest
+    ##
+    # test all routes which lead to this controller
+    def test_routes
+      assert_routing(
+        { :path => "/account/terms", :method => :get },
+        { :controller => "accounts/terms", :action => "show" }
+      )
+      assert_routing(
+        { :path => "/account/terms", :method => :put },
+        { :controller => "accounts/terms", :action => "update" }
+      )
+
+      get "/user/terms"
+      assert_redirected_to "/account/terms"
+    end
+
+    def test_show_not_logged_in
+      get account_terms_path
+
+      assert_redirected_to login_path(:referer => account_terms_path)
+    end
+
+    def test_show_agreed
+      user = create(:user, :terms_seen => true, :terms_agreed => Date.yesterday)
+      session_for(user)
+
+      get account_terms_path
+      assert_redirected_to edit_account_path
+    end
+
+    def test_show_not_seen_without_referer
+      user = create(:user, :terms_seen => false, :terms_agreed => nil)
+      session_for(user)
+
+      get account_terms_path
+      assert_response :success
+    end
+
+    def test_show_not_seen_with_referer
+      user = create(:user, :terms_seen => false, :terms_agreed => nil)
+      session_for(user)
+
+      get account_terms_path(:referer => "/test")
+      assert_response :success
+    end
+
+    def test_update_not_seen_without_referer
+      user = create(:user, :terms_seen => false, :terms_agreed => nil)
+      session_for(user)
+
+      put account_terms_path, :params => { :user => { :consider_pd => true }, :read_ct => 1, :read_tou => 1 }
+      assert_redirected_to edit_account_path
+      assert_equal "Thanks for accepting the new contributor terms!", flash[:notice]
+
+      user.reload
+
+      assert user.consider_pd
+      assert_not_nil user.terms_agreed
+      assert user.terms_seen
+    end
+
+    def test_update_not_seen_with_referer
+      user = create(:user, :terms_seen => false, :terms_agreed => nil)
+      session_for(user)
+
+      put account_terms_path, :params => { :user => { :consider_pd => true }, :referer => "/test", :read_ct => 1, :read_tou => 1 }
+      assert_redirected_to "/test"
+      assert_equal "Thanks for accepting the new contributor terms!", flash[:notice]
+
+      user.reload
+
+      assert user.consider_pd
+      assert_not_nil user.terms_agreed
+      assert user.terms_seen
+    end
+
+    # Check that if you haven't seen the terms, and make a request that requires authentication,
+    # that your request is redirected to view the terms
+    def test_terms_not_seen_redirection
+      user = create(:user, :terms_seen => false, :terms_agreed => nil)
+      session_for(user)
+
+      get edit_account_path
+      assert_redirected_to account_terms_path(:referer => "/account/edit")
+    end
+  end
+end