Add validation for page number passed to notes#index
This commit is contained in:
parent
feff501b25
commit
5d887a37bf
2 changed files with 11 additions and 0 deletions
|
@ -16,6 +16,8 @@ class NotesController < ApplicationController
|
|||
##
|
||||
# Display a list of notes by a specified user
|
||||
def index
|
||||
param! :page, Integer, :min => 1
|
||||
|
||||
@params = params.permit(:display_name)
|
||||
@title = t ".title", :user => @user.display_name
|
||||
@page = (params[:page] || 1).to_i
|
||||
|
|
|
@ -83,6 +83,15 @@ class NotesControllerTest < ActionDispatch::IntegrationTest
|
|||
assert_select "table.note_list tbody tr", :count => 10
|
||||
end
|
||||
|
||||
def test_index_invalid_paged
|
||||
user = create(:user)
|
||||
|
||||
%w[-1 0 fred].each do |page|
|
||||
get user_notes_path(user, :page => page)
|
||||
assert_redirected_to :controller => :errors, :action => :bad_request
|
||||
end
|
||||
end
|
||||
|
||||
def test_empty_page
|
||||
user = create(:user)
|
||||
get user_notes_path(user)
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue