cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Prefer keyword arguments when method has optional boolean arguments

Browse source
This commit is contained in:
Tom Hughes 2020-11-13 10:14:10 +00:00
parent 63221710a4
commit 582402ba8f
17 changed files with 91 additions and 101 deletions
Download patch file Download diff file Expand all files Collapse all files

4
lib/diff_reader.rb
View file

@ -138,7 +138,7 @@ class DiffReader
# create a new element. this code is agnostic of the element type
# because all the elements support the methods that we're using.
with_model do |model, xml|
new = model.from_xml_node(xml, true)
new = model.from_xml_node(xml, :create => true)
check(model, xml, new)
# when this element is saved it will get a new ID, so we save it
@ -174,7 +174,7 @@ class DiffReader
# with types, but uses duck typing to handle them transparently.
with_model do |model, xml|
# get the new element from the XML payload
new = model.from_xml_node(xml, false)
new = model.from_xml_node(xml, :create => false)
check(model, xml, new)
# if the ID is a placeholder then map it to the real ID