Merge remote-tracking branch 'upstream/pull/5022'

This commit is contained in:
Tom Hughes 2024-07-26 17:52:54 +01:00
commit 541f0630ac

View file

@ -27,22 +27,22 @@ class IssuesControllerTest < ActionDispatch::IntegrationTest
issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "moderator")
# Access issue without login
get issue_path(:id => issue)
get issue_path(issue)
assert_redirected_to login_path(:referer => issue_path(issue))
# Access issue as normal user
session_for(create(:user))
get issue_path(:id => issue)
get issue_path(issue)
assert_redirected_to :controller => :errors, :action => :forbidden
# Access issue as administrator
session_for(create(:administrator_user))
get issue_path(:id => issue)
get issue_path(issue)
assert_redirected_to :controller => :errors, :action => :not_found
# Access issue as moderator
session_for(create(:moderator_user))
get issue_path(:id => issue)
get issue_path(issue)
assert_response :success
end
@ -51,22 +51,22 @@ class IssuesControllerTest < ActionDispatch::IntegrationTest
issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "administrator")
# Access issue without login
get issue_path(:id => issue)
get issue_path(issue)
assert_redirected_to login_path(:referer => issue_path(issue))
# Access issue as normal user
session_for(create(:user))
get issue_path(:id => issue)
get issue_path(issue)
assert_redirected_to :controller => :errors, :action => :forbidden
# Access issue as moderator
session_for(create(:moderator_user))
get issue_path(:id => issue)
get issue_path(issue)
assert_redirected_to :controller => :errors, :action => :not_found
# Access issue as administrator
session_for(create(:administrator_user))
get issue_path(:id => issue)
get issue_path(issue)
assert_response :success
end
@ -75,23 +75,23 @@ class IssuesControllerTest < ActionDispatch::IntegrationTest
issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "moderator")
# Resolve issue without login
post resolve_issue_path(:id => issue)
post resolve_issue_path(issue)
assert_response :forbidden
# Resolve issue as normal user
session_for(create(:user))
post resolve_issue_path(:id => issue)
post resolve_issue_path(issue)
assert_redirected_to :controller => :errors, :action => :forbidden
# Resolve issue as administrator
session_for(create(:administrator_user))
post resolve_issue_path(:id => issue)
post resolve_issue_path(issue)
assert_redirected_to :controller => :errors, :action => :not_found
assert_not_predicate issue.reload, :resolved?
# Resolve issue as moderator
session_for(create(:moderator_user))
post resolve_issue_path(:id => issue)
post resolve_issue_path(issue)
assert_response :redirect
assert_predicate issue.reload, :resolved?
end
@ -101,23 +101,23 @@ class IssuesControllerTest < ActionDispatch::IntegrationTest
issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "administrator")
# Resolve issue without login
post resolve_issue_path(:id => issue)
post resolve_issue_path(issue)
assert_response :forbidden
# Resolve issue as normal user
session_for(create(:user))
post resolve_issue_path(:id => issue)
post resolve_issue_path(issue)
assert_redirected_to :controller => :errors, :action => :forbidden
# Resolve issue as moderator
session_for(create(:moderator_user))
post resolve_issue_path(:id => issue)
post resolve_issue_path(issue)
assert_redirected_to :controller => :errors, :action => :not_found
assert_not_predicate issue.reload, :resolved?
# Resolve issue as administrator
session_for(create(:administrator_user))
post resolve_issue_path(:id => issue)
post resolve_issue_path(issue)
assert_response :redirect
assert_predicate issue.reload, :resolved?
end
@ -127,23 +127,23 @@ class IssuesControllerTest < ActionDispatch::IntegrationTest
issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "moderator")
# Ignore issue without login
post ignore_issue_path(:id => issue)
post ignore_issue_path(issue)
assert_response :forbidden
# Ignore issue as normal user
session_for(create(:user))
post ignore_issue_path(:id => issue)
post ignore_issue_path(issue)
assert_redirected_to :controller => :errors, :action => :forbidden
# Ignore issue as administrator
session_for(create(:administrator_user))
post ignore_issue_path(:id => issue)
post ignore_issue_path(issue)
assert_redirected_to :controller => :errors, :action => :not_found
assert_not_predicate issue.reload, :ignored?
# Ignore issue as moderator
session_for(create(:moderator_user))
post ignore_issue_path(:id => issue)
post ignore_issue_path(issue)
assert_response :redirect
assert_predicate issue.reload, :ignored?
end
@ -153,23 +153,23 @@ class IssuesControllerTest < ActionDispatch::IntegrationTest
issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "administrator")
# Ignore issue without login
post ignore_issue_path(:id => issue)
post ignore_issue_path(issue)
assert_response :forbidden
# Ignore issue as normal user
session_for(create(:user))
post ignore_issue_path(:id => issue)
post ignore_issue_path(issue)
assert_redirected_to :controller => :errors, :action => :forbidden
# Ignore issue as moderator
session_for(create(:moderator_user))
post ignore_issue_path(:id => issue)
post ignore_issue_path(issue)
assert_redirected_to :controller => :errors, :action => :not_found
assert_not_predicate issue.reload, :ignored?
# Ignore issue as administrator
session_for(create(:administrator_user))
post ignore_issue_path(:id => issue)
post ignore_issue_path(issue)
assert_response :redirect
assert_predicate issue.reload, :ignored?
end
@ -181,23 +181,23 @@ class IssuesControllerTest < ActionDispatch::IntegrationTest
issue.resolve!
# Reopen issue without login
post reopen_issue_path(:id => issue)
post reopen_issue_path(issue)
assert_response :forbidden
# Reopen issue as normal user
session_for(create(:user))
post reopen_issue_path(:id => issue)
post reopen_issue_path(issue)
assert_redirected_to :controller => :errors, :action => :forbidden
# Reopen issue as administrator
session_for(create(:administrator_user))
post reopen_issue_path(:id => issue)
post reopen_issue_path(issue)
assert_redirected_to :controller => :errors, :action => :not_found
assert_not_predicate issue.reload, :open?
# Reopen issue as moderator
session_for(create(:moderator_user))
post reopen_issue_path(:id => issue)
post reopen_issue_path(issue)
assert_response :redirect
assert_predicate issue.reload, :open?
end
@ -209,23 +209,23 @@ class IssuesControllerTest < ActionDispatch::IntegrationTest
issue.resolve!
# Reopen issue without login
post reopen_issue_path(:id => issue)
post reopen_issue_path(issue)
assert_response :forbidden
# Reopen issue as normal user
session_for(create(:user))
post reopen_issue_path(:id => issue)
post reopen_issue_path(issue)
assert_redirected_to :controller => :errors, :action => :forbidden
# Reopen issue as moderator
session_for(create(:moderator_user))
post reopen_issue_path(:id => issue)
post reopen_issue_path(issue)
assert_redirected_to :controller => :errors, :action => :not_found
assert_not_predicate issue.reload, :open?
# Reopen issue as administrator
session_for(create(:administrator_user))
post reopen_issue_path(:id => issue)
post reopen_issue_path(issue)
assert_response :redirect
assert_predicate issue.reload, :open?
end