Remove the changesets_subscribers fixture.

Since there is no ChangesetsSubscribers model, we can't use a factory.
Instead we create the associations explicitly when needed.
This commit is contained in:
Andy Allan 2016-10-30 12:23:23 +01:00
parent 48eb8eb369
commit 4eeea7e705
3 changed files with 11 additions and 19 deletions

View file

@ -64,7 +64,7 @@ Metrics/BlockNesting:
# Offense count: 62 # Offense count: 62
# Configuration parameters: CountComments. # Configuration parameters: CountComments.
Metrics/ClassLength: Metrics/ClassLength:
Max: 1652 Max: 1658
# Offense count: 69 # Offense count: 69
Metrics/CyclomaticComplexity: Metrics/CyclomaticComplexity:

View file

@ -3,7 +3,6 @@ require "changeset_controller"
class ChangesetControllerTest < ActionController::TestCase class ChangesetControllerTest < ActionController::TestCase
api_fixtures api_fixtures
fixtures :changesets_subscribers
## ##
# test all routes which lead to this controller # test all routes which lead to this controller
@ -1986,9 +1985,15 @@ EOF
end end
assert_response :success assert_response :success
changeset = changesets(:normal_user_subscribed_change)
changeset.subscribers.push(users(:normal_user))
changeset.subscribers.push(users(:public_user))
changeset.subscribers.push(users(:suspended_user))
changeset.subscribers.push(users(:deleted_user))
assert_difference "ChangesetComment.count", 1 do assert_difference "ChangesetComment.count", 1 do
assert_difference "ActionMailer::Base.deliveries.size", 1 do assert_difference "ActionMailer::Base.deliveries.size", 1 do
post :comment, :id => changesets(:normal_user_subscribed_change).id, :text => "This is a comment" post :comment, :id => changeset.id, :text => "This is a comment"
end end
end end
assert_response :success assert_response :success
@ -2004,7 +2009,7 @@ EOF
assert_difference "ChangesetComment.count", 1 do assert_difference "ChangesetComment.count", 1 do
assert_difference "ActionMailer::Base.deliveries.size", 2 do assert_difference "ActionMailer::Base.deliveries.size", 2 do
post :comment, :id => changesets(:normal_user_subscribed_change).id, :text => "This is a comment" post :comment, :id => changeset.id, :text => "This is a comment"
end end
end end
assert_response :success assert_response :success
@ -2095,6 +2100,7 @@ EOF
# trying to subscribe when already subscribed # trying to subscribe when already subscribed
changeset = changesets(:normal_user_subscribed_change) changeset = changesets(:normal_user_subscribed_change)
changeset.subscribers.push(users(:public_user))
assert_no_difference "changeset.subscribers.count" do assert_no_difference "changeset.subscribers.count" do
post :subscribe, :id => changeset.id post :subscribe, :id => changeset.id
end end
@ -2106,6 +2112,7 @@ EOF
def test_unsubscribe_success def test_unsubscribe_success
basic_authorization(users(:public_user).email, "test") basic_authorization(users(:public_user).email, "test")
changeset = changesets(:normal_user_subscribed_change) changeset = changesets(:normal_user_subscribed_change)
changeset.subscribers.push(users(:public_user))
assert_difference "changeset.subscribers.count", -1 do assert_difference "changeset.subscribers.count", -1 do
post :unsubscribe, :id => changeset.id post :unsubscribe, :id => changeset.id

View file

@ -1,15 +0,0 @@
t1:
changeset_id: 8
subscriber_id: 2
t2:
changeset_id: 8
subscriber_id: 1
t3:
changeset_id: 8
subscriber_id: 10
t4:
changeset_id: 8
subscriber_id: 11