cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Defer measuring of header elements to a timeout

Browse source 
Chrome 60 and later seem to fire the "ready" callback before the DOM is
fully ready causing us to measure the wrong sizes for the header elements
so we use a 0ms timeout to defer the measurement slightly as a workaround.

Fixes #1639
This commit is contained in:
Tom Hughes 2017-09-14 20:30:38 +01:00
parent 715759211a
commit 47d33ed98e
1 changed files with 22 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

32
app/assets/javascripts/application.js
View file

@ -79,18 +79,6 @@ $(document).ready(function () {
var headerWidth = 0,
compactWidth = 0;
$("header").children(":visible").each(function (i,e) {
headerWidth = headerWidth + $(e).outerWidth();
});
$("body").addClass("compact");
$("header").children(":visible").each(function (i,e) {
compactWidth = compactWidth + $(e).outerWidth();
});
$("body").removeClass("compact");
function updateHeader() {
var windowWidth = $(window).width();
@ -103,9 +91,29 @@ $(document).ready(function () {
}
}
/*
* Chrome 60 and later seem to fire the "ready" callback
* before the DOM is fully ready causing us to measure the
* wrong sizes for the header elements - use a 0ms timeout
* to defer the measurement slightly as a workaround.
*/
setTimeout(function () {
$("header").children(":visible").each(function (i,e) {
headerWidth = headerWidth + $(e).outerWidth();
});
$("body").addClass("compact");
$("header").children(":visible").each(function (i,e) {
compactWidth = compactWidth + $(e).outerWidth();
});
$("body").removeClass("compact");
updateHeader();
$(window).resize(updateHeader);
}, 0);
$("#menu-icon").on("click", function(e) {
e.preventDefault();