cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Improve consistency of trace upload forms and error handling.

Browse source 
Fixes #543 and #544.
This commit is contained in:
Tom Hughes 2007-09-25 23:18:32 +00:00
parent 68637a381c
commit 3db4ac9a8e
4 changed files with 33 additions and 41 deletions
Download patch file Download diff file Expand all files Collapse all files

9
app/views/trace/_trace_form.rhtml Normal file
View file

@ -0,0 +1,9 @@
<% form_for :trace, @trace, :url => { :action => "create" }, :html => { :multipart => true } do |f| %>
<table>
<tr><td align="right">Upload GPX File</td><td><%= f.file_field :gpx_file, :size => 50, :maxlength => 255 %></td></tr>
<tr><td align="right">Description</td><td><%= f.text_field :description, :size => 50, :maxlength => 255 %></td></tr>
<tr><td align="right">Tags</td><td><%= f.text_field :tagstring, :size => 50, :maxlength => 255 %></td></tr>
<tr><td align="right">Public?</td><td><%= f.check_box :public %></td></tr>
<tr><td></td><td><%= submit_tag 'Upload' %> | <a href="http://wiki.openstreetmap.org/index.php/Upload">Help</a></td></tr>
</table>
<% end %>

12
app/views/trace/create.rhtml
View file

@ -2,14 +2,4 @@
<%= error_messages_for 'trace' %>
<% form_tag({:action => 'create'}, :multipart => true) do %>
<table>
<tr><td align="right">Upload GPX File</td><td><%= file_field('trace', 'gpx_file', {:size => 50, :maxlength => 255}) %></td></tr>
<tr><td align="right">Description</td><td><%= text_field('trace', 'description', {:size => 50, :maxlength => 255}) %></td></tr>
<tr><td align="right">Tags</td><td><%= text_field('trace', 'tagstring', {:size => 50, :maxlength => 255}) %></td></tr>
<tr><td align="right">Public?</td><td><%= check_box('trace', 'public') %></td></tr>
<tr><td></td><td>
<%= submit_tag 'Upload' %> | <a href="http://wiki.openstreetmap.org/index.php/Upload">help</a>
</td></tr>
</table>
<% end %>
<%= render :partial => 'trace_form' %>

15
app/views/trace/mine.rhtml
View file

@ -1,16 +1,3 @@
<%= render :partial => 'trace_header' %>
<% form_tag({:action => 'create'}, :multipart => true) do %>
<table>
<table>
<tr><td align="right">upload GPX file:</td><td><%= file_field('trace', 'gpx_file', {:size => 50, :maxlength => 255}) %></td></tr>
<tr><td align="right">description:</td><td><%= text_field('trace', 'description', {:size => 50, :maxlength => 255}) %></td></tr>
<tr><td align="right">tags:</td><td><%= text_field('trace', 'tagstring', {:size => 50, :maxlength => 255}) %></td></tr>
<tr><td align="right">public?</td><td><%= check_box('trace', 'public', {:checked => 'checked'}) %></td></tr>
<tr><td></td><td>
<%= submit_tag 'Upload' %> | <a href="http://wiki.openstreetmap.org/index.php/Upload">help</a>
</td></tr>
</table>
<% end %>
<%= render :partial => 'trace_form' %>
<%= render :partial => 'trace_list' %>