cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use assert_not_predicate in tests that have assert_predicate

Browse source
This commit is contained in:
Anton Khorev 2024-01-03 16:01:17 +03:00
parent 6892ccd015
commit 3a8a997fb8
26 changed files with 91 additions and 91 deletions
Download patch file Download diff file Expand all files Collapse all files

8
test/models/redaction_test.rb
View file

@ -4,7 +4,7 @@ class RedactionTest < ActiveSupport::TestCase
def test_cannot_redact_current
n = create(:node)
r = create(:redaction)
assert_not(n.redacted?, "Expected node to not be redacted already.")
assert_not_predicate(n, :redacted?, "Expected node to not be redacted already.")
assert_raise(OSM::APICannotRedactError) do
n.redact!(r)
end
@ -14,7 +14,7 @@ class RedactionTest < ActiveSupport::TestCase
node = create(:node, :with_history)
node_v1 = node.old_nodes.find_by(:version => 1)
r = create(:redaction)
assert_not(node_v1.redacted?, "Expected node to not be redacted already.")
assert_not_predicate(node_v1, :redacted?, "Expected node to not be redacted already.")
assert_raise(OSM::APICannotRedactError) do
node_v1.redact!(r)
end
@ -26,11 +26,11 @@ class RedactionTest < ActiveSupport::TestCase
node_v2 = node.old_nodes.find_by(:version => 2)
r = create(:redaction)
assert_not(node_v1.redacted?, "Expected node to not be redacted already.")
assert_not_predicate(node_v1, :redacted?, "Expected node to not be redacted already.")
assert_nothing_raised do
node_v1.redact!(r)
end
assert_predicate(node_v1, :redacted?, "Expected node version 1 to be redacted after redact! call.")
assert_not(node_v2.redacted?, "Expected node version 2 to not be redacted after redact! call.")
assert_not_predicate(node_v2, :redacted?, "Expected node version 2 to not be redacted after redact! call.")
end
end