cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Refactor api changeset comment visibility json tests

Browse source
This commit is contained in:
Anton Khorev 2025-02-23 06:38:43 +03:00
parent c88770e4ce
commit 3765a7e89e
1 changed files with 15 additions and 32 deletions
Download patch file Download diff file Expand all files Collapse all files

47
test/controllers/api/changeset_comments/visibilities_controller_test.rb
View file

@ -93,14 +93,7 @@ module Api
post api_changeset_comment_visibility_path(comment, :format => "json"), :headers => auth_header post api_changeset_comment_visibility_path(comment, :format => "json"), :headers => auth_header
assert_response :success check_successful_response_json(comment, :comment_visible => true)
assert_equal "application/json", response.media_type
js = ActiveSupport::JSON.decode(@response.body)
assert_not_nil js["changeset"]
assert_equal comment.changeset_id, js["changeset"]["id"]
assert_equal 1, js["changeset"]["comments_count"]
assert comment.reload.visible
end end
def test_create_with_write_api_scope def test_create_with_write_api_scope
@ -118,14 +111,7 @@ module Api
post api_changeset_comment_visibility_path(comment, :format => "json"), :headers => auth_header post api_changeset_comment_visibility_path(comment, :format => "json"), :headers => auth_header
assert_response :success check_successful_response_json(comment, :comment_visible => true)
js = ActiveSupport::JSON.decode(@response.body)
assert_equal "application/json", response.media_type
assert_not_nil js["changeset"]
assert_equal comment.changeset_id, js["changeset"]["id"]
assert_equal 1, js["changeset"]["comments_count"]
assert comment.reload.visible
end end
def test_destroy_by_unauthorized def test_destroy_by_unauthorized
@ -180,14 +166,7 @@ module Api
delete api_changeset_comment_visibility_path(comment, :format => "json"), :headers => auth_header delete api_changeset_comment_visibility_path(comment, :format => "json"), :headers => auth_header
assert_response :success check_successful_response_json(comment, :comment_visible => false)
assert_equal "application/json", response.media_type
js = ActiveSupport::JSON.decode(@response.body)
assert_not_nil js["changeset"]
assert_equal comment.changeset_id, js["changeset"]["id"]
assert_equal 0, js["changeset"]["comments_count"]
assert_not comment.reload.visible
end end
def test_destroy_with_write_api_scope def test_destroy_with_write_api_scope
@ -205,14 +184,7 @@ module Api
delete api_changeset_comment_visibility_path(comment, :format => "json"), :headers => auth_header delete api_changeset_comment_visibility_path(comment, :format => "json"), :headers => auth_header
assert_response :success check_successful_response_json(comment, :comment_visible => false)
assert_equal "application/json", response.media_type
js = ActiveSupport::JSON.decode(@response.body)
assert_not_nil js["changeset"]
assert_equal comment.changeset_id, js["changeset"]["id"]
assert_equal 0, js["changeset"]["comments_count"]
assert_not comment.reload.visible
end end
private private
@ -229,6 +201,17 @@ module Api
assert_equal comment_visible, comment.reload.visible assert_equal comment_visible, comment.reload.visible
end end
def check_successful_response_json(comment, comment_visible:)
assert_response :success
assert_equal "application/json", response.media_type
js = ActiveSupport::JSON.decode(@response.body)
assert_not_nil js["changeset"]
assert_equal comment.changeset_id, js["changeset"]["id"]
assert_equal comment_visible ? 1 : 0, js["changeset"]["comments_count"]
assert_equal comment_visible, comment.reload.visible
end
end end
end end
end end