cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Require display names to have a minimum unicode width of 3 columns

Browse source 
Fixes #4538
This commit is contained in:
Tom Hughes 2024-02-25 13:16:40 +00:00
parent a1a6c577e8
commit 3360f91733
6 changed files with 30 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

12
test/models/user_test.rb
View file

@ -67,6 +67,18 @@ class UserTest < ActiveSupport::TestCase
assert_not_predicate user, :valid?, "should not allow nil value"
end
def test_display_name_width
user = build(:user)
user.display_name = "123"
assert_predicate user, :valid?, "should allow 3 column name name"
user.display_name = "12"
assert_not_predicate user, :valid?, "should not allow 2 column name"
user.display_name = "1\u{200B}2"
assert_not_predicate user, :valid?, "should not allow 2 column name"
user.display_name = "\u{200B}\u{200B}\u{200B}"
assert_not_predicate user, :valid?, "should not allow 0 column name"
end
def test_display_name_valid
# Due to sanitisation in the view some of these that you might not
# expect are allowed