cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Avoid unnecessary array allocations

Browse source
This commit is contained in:
John Firebaugh 2012-10-21 20:31:29 -07:00 • committed by Tom Hughes
parent e64bcf335a
commit 31dae1bac1
1 changed files with 5 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

14
app/models/relation.rb
View file

@ -167,13 +167,9 @@ class Relation < ActiveRecord::Base
# FIXME is this really needed?
def members
unless @members
@members = Array.new
self.relation_members.each do |member|
@members += [[member.member_type,member.member_id,member.member_role]]
end
@members ||= self.relation_members.map do |member|
[member.member_type, member.member_id, member.member_role]
end
@members
end
def tags
@ -194,9 +190,9 @@ class Relation < ActiveRecord::Base
@tags = t
end
def add_member(type,id,role)
@members = Array.new unless @members
@members += [[type,id.to_i,role]]
def add_member(type, id, role)
@members ||= []
@members << [type, id.to_i, role]
end
def add_tag_keyval(k, v)