cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add a redirect and error message if user ends up trying to report something without the correct parameters

Browse source
This commit is contained in:
Andy Allan 2018-03-14 17:09:57 +08:00
parent 85bf9adb91
commit 2fc70be734
3 changed files with 14 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
app/controllers/reports_controller.rb
View file

@ -5,9 +5,11 @@ class ReportsController < ApplicationController
before_action :require_user
def new
if create_new_report_params.present?
if required_new_report_params_present?
@report = Report.new
@report.issue = Issue.find_or_initialize_by(create_new_report_params)
else
redirect_to root_path, :notice => t("reports.new.missing_params")
end
end
@ -26,6 +28,10 @@ class ReportsController < ApplicationController
private
def required_new_report_params_present?
create_new_report_params['reportable_id'].present? && create_new_report_params['reportable_type'].present?
end
def create_new_report_params
params.permit(:reportable_id, :reportable_type)
end