Refactor reportable_url helper to focus on just the title choices.

This commit is contained in:
Andy Allan 2018-02-28 11:53:43 +08:00
parent 38efcc2f33
commit 2a89bf2e6c
3 changed files with 14 additions and 15 deletions

View file

@ -15,19 +15,18 @@ module IssuesHelper
end
end
def reports_url(issue)
class_name = issue.reportable.class.name
case class_name
when "DiaryEntry"
link_to issue.reportable.title, issue
when "User"
link_to issue.reportable.display_name.to_s, issue
when "DiaryComment"
link_to "#{issue.reportable.diary_entry.title}, Comment id ##{issue.reportable.id}", issue
when "Changeset"
link_to "Changeset ##{issue.reportable.id}", issue
when "Note"
link_to "Note ##{issue.reportable.id}", issue
def reportable_title(reportable)
case reportable
when DiaryEntry
reportable.title
when User
reportable.display_name
when DiaryComment
"#{reportable.diary_entry.title}, Comment id ##{reportable.id}"
when Changeset
"Changeset ##{reportable.id}"
when Note
"Note ##{reportable.id}"
end
end