cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add closed_by attribute to :closed note factory trait

Browse source
This commit is contained in:
Anton Khorev 2024-01-05 13:04:06 +03:00
parent 6272b041c6
commit 1efbdb2d6c
2 changed files with 7 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
test/controllers/notes_controller_test.rb
View file

@ -144,9 +144,7 @@ class NotesControllerTest < ActionDispatch::IntegrationTest
def test_read_closed_note
user = create(:user)
closed_note = create(:note_with_comments, :status => "closed", :closed_at => Time.now.utc, :comments_count => 2) do |note|
create(:note_comment, :event => "closed", :note => note, :author => user)
end
closed_note = create(:note_with_comments, :closed, :closed_by => user, :comments_count => 2)
browse_check :note_path, closed_note.id, "notes/show"
assert_select "div.note-comments ul li", :count => 2

8
test/factories/notes.rb
View file

@ -5,11 +5,15 @@ FactoryBot.define do
# tile { QuadTile.tile_for_point(1,1) }
trait :closed do
transient do
closed_by { nil }
end
status { "closed" }
closed_at { Time.now.utc }
after(:create) do |note|
create(:note_comment, :body => "Closing comment", :event => "closed", :note => note)
after(:create) do |note, context|
create(:note_comment, :author => context.closed_by, :body => "Closing comment", :event => "closed", :note => note)
end
end