cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

iD: listen to manual hashchanges from iframe parent

Browse source 
Pan to the new `map` location when the hash change was not not triggered by map interaction from inside iD itself.

This mirrors the behaviour when manually editing the `map` hash parameter on osm.org outside of iD.

This also fixes https://github.com/openstreetmap/iD/issues/10592 (error in js console when iD is opened outside of an iframe by directly navigating to osm.org/id).
This commit is contained in:
Martin Raifer 2024-12-11 14:59:02 +01:00
parent 985b355d1c
commit 1ba5b7fef0
No known key found for this signature in database
GPG key ID: 3CD561F7B1C461BD
1 changed files with 24 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

28
app/assets/javascripts/id.js
View file

@ -28,6 +28,12 @@ document.addEventListener("DOMContentLoaded", function () {
.containerNode(container)
.init();
if (parent === window) {
// iD not opened in an iframe -> skip setting of parent handlers
return;
}
var hashChangedAutomatically = false;
id.map().on("move.embed", parent.$.throttle(250, function () {
if (id.inIntro()) return;
var zoom = ~~id.map().zoom(),
@ -40,14 +46,12 @@ document.addEventListener("DOMContentLoaded", function () {
// https://gist.github.com/jfirebaugh/5439412
var hash = parent.OSM.formatHash(llz);
if (hash !== parent.location.hash) {
hashChangedAutomatically = true;
parent.location.replace(parent.location.href.replace(/(#.*|$)/, hash));
}
}));
parent.$("body").on("click", "a.set_position", function (e) {
e.preventDefault();
var data = parent.$(this).data();
function goToLocation(data) {
// 0ms timeout to avoid iframe JS context weirdness.
// https://gist.github.com/jfirebaugh/5439412
setTimeout(function () {
@ -55,6 +59,22 @@ document.addEventListener("DOMContentLoaded", function () {
[data.lon, data.lat],
Math.max(data.zoom || 15, 13));
}, 0);
}
parent.$("body").on("click", "a.set_position", function (e) {
e.preventDefault();
var data = parent.$(this).data();
goToLocation(data);
});
parent.addEventListener("hashchange", function (e) {
if (hashChangedAutomatically) {
hashChangedAutomatically = false;
return;
}
e.preventDefault();
var data = parent.OSM.mapParams();
goToLocation(data);
});
}
});