Fix new rubocop warnings

This commit is contained in:
Tom Hughes 2020-09-07 07:11:22 +01:00
parent feb1412109
commit 18b9b9f14c
4 changed files with 10 additions and 10 deletions

View file

@ -904,7 +904,7 @@ module Api
# Alternative SQL queries for getway/whichways # Alternative SQL queries for getway/whichways
def sql_find_ways_in_area(bbox) def sql_find_ways_in_area(bbox)
sql = <<~SQL sql = <<~SQL.squish
SELECT DISTINCT current_ways.id AS wayid,current_ways.version AS version SELECT DISTINCT current_ways.id AS wayid,current_ways.version AS version
FROM current_way_nodes FROM current_way_nodes
INNER JOIN current_nodes ON current_nodes.id=current_way_nodes.node_id INNER JOIN current_nodes ON current_nodes.id=current_way_nodes.node_id
@ -918,7 +918,7 @@ module Api
def sql_find_pois_in_area(bbox) def sql_find_pois_in_area(bbox)
pois = [] pois = []
sql = <<~SQL sql = <<~SQL.squish
SELECT current_nodes.id,current_nodes.latitude*0.0000001 AS lat,current_nodes.longitude*0.0000001 AS lon,current_nodes.version SELECT current_nodes.id,current_nodes.latitude*0.0000001 AS lat,current_nodes.longitude*0.0000001 AS lon,current_nodes.version
FROM current_nodes FROM current_nodes
LEFT OUTER JOIN current_way_nodes cwn ON cwn.node_id=current_nodes.id LEFT OUTER JOIN current_way_nodes cwn ON cwn.node_id=current_nodes.id
@ -939,7 +939,7 @@ module Api
def sql_find_relations_in_area_and_ways(bbox, way_ids) def sql_find_relations_in_area_and_ways(bbox, way_ids)
# ** It would be more Potlatchy to get relations for nodes within ways # ** It would be more Potlatchy to get relations for nodes within ways
# during 'getway', not here # during 'getway', not here
sql = <<~SQL sql = <<~SQL.squish
SELECT DISTINCT cr.id AS relid,cr.version AS version SELECT DISTINCT cr.id AS relid,cr.version AS version
FROM current_relations cr FROM current_relations cr
INNER JOIN current_relation_members crm ON crm.id=cr.id INNER JOIN current_relation_members crm ON crm.id=cr.id
@ -947,7 +947,7 @@ module Api
WHERE #{OSM.sql_for_area(bbox, 'cn.')} WHERE #{OSM.sql_for_area(bbox, 'cn.')}
SQL SQL
unless way_ids.empty? unless way_ids.empty?
sql += <<~SQL sql += <<~SQL.squish
UNION UNION
SELECT DISTINCT cr.id AS relid,cr.version AS version SELECT DISTINCT cr.id AS relid,cr.version AS version
FROM current_relations cr FROM current_relations cr
@ -961,7 +961,7 @@ module Api
def sql_get_nodes_in_way(wayid) def sql_get_nodes_in_way(wayid)
points = [] points = []
sql = <<~SQL sql = <<~SQL.squish
SELECT latitude*0.0000001 AS lat,longitude*0.0000001 AS lon,current_nodes.id,current_nodes.version SELECT latitude*0.0000001 AS lat,longitude*0.0000001 AS lon,current_nodes.id,current_nodes.version
FROM current_way_nodes,current_nodes FROM current_way_nodes,current_nodes
WHERE current_way_nodes.id=#{wayid.to_i} WHERE current_way_nodes.id=#{wayid.to_i}

View file

@ -202,7 +202,7 @@ class User < ApplicationRecord
sql_for_area = QuadTile.sql_for_area(gc.bounds(radius), "home_") sql_for_area = QuadTile.sql_for_area(gc.bounds(radius), "home_")
sql_for_distance = gc.sql_for_distance("home_lat", "home_lon") sql_for_distance = gc.sql_for_distance("home_lat", "home_lon")
nearby = User.active.identifiable nearby = User.active.identifiable
.where("id != ?", id) .where.not(:id => id)
.where(sql_for_area) .where(sql_for_area)
.where("#{sql_for_distance} <= ?", radius) .where("#{sql_for_distance} <= ?", radius)
.order(Arel.sql(sql_for_distance)) .order(Arel.sql(sql_for_distance))

View file

@ -24,7 +24,7 @@ class UserEnhancements < ActiveRecord::Migration[4.2]
add_index "user_tokens", ["token"], :name => "user_tokens_token_idx", :unique => true add_index "user_tokens", ["token"], :name => "user_tokens_token_idx", :unique => true
add_index "user_tokens", ["user_id"], :name => "user_tokens_user_id_idx" add_index "user_tokens", ["user_id"], :name => "user_tokens_user_id_idx"
User.where("token is not null").each do |user| User.where.not(:token => nil).each do |user|
UserToken.create(:user_id => user.id, :token => user.token, :expiry => 1.week.from_now) UserToken.create(:user_id => user.id, :token => user.token, :expiry => 1.week.from_now)
end end

View file

@ -11,7 +11,7 @@ class TileNodes < ActiveRecord::Migration[4.2]
def self.upgrade_table(from_table, to_table, model) def self.upgrade_table(from_table, to_table, model)
if ENV["USE_DB_FUNCTIONS"] if ENV["USE_DB_FUNCTIONS"]
execute <<-SQL execute <<-SQL.squish
INSERT INTO #{to_table} (id, latitude, longitude, user_id, visible, tags, timestamp, tile) INSERT INTO #{to_table} (id, latitude, longitude, user_id, visible, tags, timestamp, tile)
SELECT id, ROUND(latitude * 10000000), ROUND(longitude * 10000000), SELECT id, ROUND(latitude * 10000000), ROUND(longitude * 10000000),
user_id, visible, tags, timestamp, user_id, visible, tags, timestamp,
@ -20,7 +20,7 @@ class TileNodes < ActiveRecord::Migration[4.2]
FROM #{from_table} FROM #{from_table}
SQL SQL
else else
execute <<-SQL execute <<-SQL.squish
INSERT INTO #{to_table} (id, latitude, longitude, user_id, visible, tags, timestamp, tile) INSERT INTO #{to_table} (id, latitude, longitude, user_id, visible, tags, timestamp, tile)
SELECT id, ROUND(latitude * 10000000), ROUND(longitude * 10000000), SELECT id, ROUND(latitude * 10000000), ROUND(longitude * 10000000),
user_id, visible, tags, timestamp, 0 user_id, visible, tags, timestamp, 0
@ -32,7 +32,7 @@ class TileNodes < ActiveRecord::Migration[4.2]
end end
def self.downgrade_table(from_table, to_table) def self.downgrade_table(from_table, to_table)
execute <<-SQL execute <<-SQL.squish
INSERT INTO #{to_table} (id, latitude, longitude, user_id, visible, tags, timestamp) INSERT INTO #{to_table} (id, latitude, longitude, user_id, visible, tags, timestamp)
SELECT id, latitude / 10000000, longitude / 10000000, SELECT id, latitude / 10000000, longitude / 10000000,
user_id, visible, tags, timestamp user_id, visible, tags, timestamp