cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Move controller tests for new reports into seperate file, and adapt to new form structure.

Browse source
This commit is contained in:
Andy Allan 2017-11-29 17:59:42 +00:00
parent 8e859b0f1d
commit 1766c3216f
2 changed files with 135 additions and 127 deletions
Download patch file Download diff file Expand all files Collapse all files

127
test/controllers/issues_controller_test.rb
View file

@ -29,133 +29,6 @@ class IssuesControllerTest < ActionController::TestCase
assert_response :success
end
def test_new_issue_without_login
# Test creation of a new issue and a new report without logging in
get :new, :params => { :reportable_id => 1, :reportable_type => "User", :reported_user_id => 1 }
assert_response :redirect
assert_redirected_to login_path(:referer => new_issue_path(:reportable_id => 1, :reportable_type => "User", :reported_user_id => 1))
end
def test_new_issue_after_login
# Test creation of a new issue and a new report
target_user = create(:user)
# Login
session[:user] = create(:user).id
assert_equal Issue.count, 0
# Create an Issue and a report
get :new, :params => { :reportable_id => target_user.id, :reportable_type => "User", :reported_user_id => target_user.id }
assert_response :success
assert_difference "Issue.count", 1 do
details = "Details of a report"
post :create,
:params => {
:report => { :details => details },
:report_type => "[OFFENSIVE]",
:issue => { :reportable_id => target_user.id, :reportable_type => "User", :reported_user_id => target_user.id }
}
end
assert_equal Issue.count, 1
assert_response :redirect
assert_redirected_to root_path
end
def test_new_report_with_incomplete_details
# Test creation of a new issue and a new report
target_user = create(:user)
# Login
session[:user] = create(:user).id
assert_equal Issue.count, 0
# Create an Issue and a report
get :new, :params => { :reportable_id => target_user.id, :reportable_type => "User", :reported_user_id => target_user.id }
assert_response :success
assert_difference "Issue.count", 1 do
details = "Details of a report"
post :create,
:params => {
:report => { :details => details },
:report_type => "[OFFENSIVE]",
:issue => { :reportable_id => target_user.id, :reportable_type => "User", :reported_user_id => target_user.id }
}
end
assert_equal Issue.count, 1
assert_response :redirect
assert_redirected_to root_path
get :new, :params => { :reportable_id => target_user.id, :reportable_type => "User", :reported_user_id => target_user.id }
assert_response :success
# Report without report_type
assert_no_difference "Issue.count" do
details = "Details of another report under the same issue"
post :create,
:params => {
:report => { :details => details },
:issue => { :reportable_id => target_user.id, :reportable_type => "User", :reported_user_id => target_user.id }
}
end
assert_response :redirect
assert_equal Issue.find_by(:reportable_id => target_user.id, :reportable_type => "User").reports.count, 1
# Report without details
assert_no_difference "Issue.count" do
post :create,
:params => {
:report_type => "[OFFENSIVE]",
:issue => { :reportable_id => 1, :reportable_type => "User", :reported_user_id => 2 }
}
end
assert_response :redirect
assert_equal Issue.find_by(:reportable_id => target_user.id, :reportable_type => "User").reports.count, 1
end
def test_new_report_with_complete_details
# Test creation of a new issue and a new report
target_user = create(:user)
# Login
session[:user] = create(:user).id
assert_equal Issue.count, 0
# Create an Issue and a report
get :new, :params => { :reportable_id => target_user.id, :reportable_type => "User", :reported_user_id => target_user.id }
assert_response :success
assert_difference "Issue.count", 1 do
details = "Details of a report"
post :create,
:params => {
:report => { :details => details },
:report_type => "[OFFENSIVE]",
:issue => { :reportable_id => target_user.id, :reportable_type => "User", :reported_user_id => target_user.id }
}
end
assert_equal Issue.count, 1
assert_response :redirect
assert_redirected_to root_path
# Create a report for an existing Issue
get :new, :params => { :reportable_id => target_user.id, :reportable_type => "User", :reported_user_id => target_user.id }
assert_response :success
assert_no_difference "Issue.count" do
details = "Details of another report under the same issue"
post :create,
:params => {
:report => { :details => details },
:report_type => "[OFFENSIVE]",
:issue => { :reportable_id => target_user.id, :reportable_type => "User", :reported_user_id => target_user.id }
}
end
assert_response :redirect
report_count = Issue.find_by(:reportable_id => target_user.id, :reportable_type => "User").reports.count
assert_equal report_count, 2
end
def test_change_status_by_normal_user
target_user = create(:user)
issue = create(:issue, :reportable => target_user, :reported_user => target_user)

135
test/controllers/reports_controller_test.rb Normal file
View file

@ -0,0 +1,135 @@
require "test_helper"
class ReportsControllerTest < ActionController::TestCase
def test_new_report_without_login
target_user = create(:user)
get :new, :params => { :reportable_id => target_user.id, :reportable_type => "User" }
assert_response :redirect
assert_redirected_to login_path(:referer => new_report_path(:reportable_id => target_user.id, :reportable_type => "User"))
end
def test_new_report_after_login
target_user = create(:user)
session[:user] = create(:user).id
assert_equal Issue.count, 0
# Create an Issue and a report
get :new, :params => { :reportable_id => target_user.id, :reportable_type => "User" }
assert_response :success
assert_difference "Issue.count", 1 do
details = "Details of a report"
post :create,
:params => {
:report => {
:details => details,
:issue => { :reportable_id => target_user.id, :reportable_type => "User" }
}
}
end
assert_equal Issue.count, 1
assert_response :redirect
assert_redirected_to root_path
end
def test_new_report_with_incomplete_details
# Test creation of a new issue and a new report
target_user = create(:user)
# Login
session[:user] = create(:user).id
assert_equal Issue.count, 0
# Create an Issue and a report
get :new, :params => { :reportable_id => target_user.id, :reportable_type => "User" }
assert_response :success
assert_difference "Issue.count", 1 do
details = "Details of a report"
post :create,
:params => {
:report => {
:details => details,
:issue => { :reportable_id => target_user.id, :reportable_type => "User" }
}
}
end
assert_equal Issue.count, 1
assert_response :redirect
assert_redirected_to root_path
get :new, :params => { :reportable_id => target_user.id, :reportable_type => "User" }
assert_response :success
# Report without report_type
assert_no_difference "Issue.count" do
details = "Details of another report under the same issue"
post :create,
:params => {
:report => {
:details => details,
:issue => { :reportable_id => target_user.id, :reportable_type => "User" }
}
}
end
assert_response :redirect
assert_equal Issue.find_by(:reportable_id => target_user.id, :reportable_type => "User").reports.count, 1
# Report without details
assert_no_difference "Issue.count" do
post :create,
:params => {
:report => {
:issue => { :reportable_id => 1, :reportable_type => "User" }
}
}
end
assert_response :redirect
assert_equal Issue.find_by(:reportable_id => target_user.id, :reportable_type => "User").reports.count, 1
end
def test_new_report_with_complete_details
# Test creation of a new issue and a new report
target_user = create(:user)
# Login
session[:user] = create(:user).id
assert_equal Issue.count, 0
# Create an Issue and a report
get :new, :params => { :reportable_id => target_user.id, :reportable_type => "User" }
assert_response :success
assert_difference "Issue.count", 1 do
details = "Details of a report"
post :create,
:params => {
:report => {
:details => details,
:issue => { :reportable_id => target_user.id, :reportable_type => "User" }
}
}
end
assert_equal Issue.count, 1
assert_response :redirect
assert_redirected_to root_path
# Create a report for an existing Issue
get :new, :params => { :reportable_id => target_user.id, :reportable_type => "User" }
assert_response :success
assert_no_difference "Issue.count" do
details = "Details of another report under the same issue"
post :create,
:params => {
:report => {
:details => details,
:issue => { :reportable_id => target_user.id, :reportable_type => "User" }
}
}
end
assert_response :redirect
report_count = Issue.find_by(:reportable_id => target_user.id, :reportable_type => "User").reports.count
assert_equal report_count, 2
end
end