Report an error if a bogus limit value is passed to a notes API call

2013-12-05 17:57:12 +00:00 · 2013-12-05 17:57:12 +00:00 · 0f2958aed4
commit 0f2958aed4
parent c866d28fd4
2 changed files with 26 additions and 4 deletions
--- a/app/controllers/notes_controller.rb
+++ b/app/controllers/notes_controller.rb
@ -308,8 +308,12 @@ private
  ##
  # Get the maximum number of results to return
  def result_limit
-    if params[:limit] and params[:limit].to_i > 0 and params[:limit].to_i < 10000
-      params[:limit].to_i
+    if params[:limit]
+      if params[:limit].to_i > 0 and params[:limit].to_i < 10000
+        params[:limit].to_i
+      else
+        raise OSM::APIBadUserInput.new("Note limit must be between 1 and 9999")
+      end
    else
      100
    end