cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Avoid polluting the global scope

Browse source 
Only startBrowse and startExport need to be exposed;
everything else can be scoped inside those functions.
This commit is contained in:
John Firebaugh 2012-08-26 16:36:05 -07:00 • committed by Tom Hughes
parent 5aa09fbfd0
commit 07c997d1d2
2 changed files with 756 additions and 756 deletions
Download patch file Download diff file Expand all files Collapse all files

4
app/assets/javascripts/browse.js
View file

@ -1,3 +1,4 @@
function startBrowse(sidebarHtml) {
var browseBoxControl;
var browseMode = "auto";
var browseBounds;
@ -11,7 +12,6 @@ var areasHidden = false;
OpenLayers.Feature.Vector.style['default'].strokeWidth = 3;
OpenLayers.Feature.Vector.style['default'].cursor = "pointer";
function startBrowse(sidebarHtml) {
map.dataLayer.active = true;
$("#sidebar_title").html(I18n.t('browse.start_rjs.data_frame_title'));
@ -42,7 +42,6 @@ function startBrowse(sidebarHtml) {
$("#browse_hide_areas_box").html(I18n.t('browse.start_rjs.hide_areas'));
$("#browse_hide_areas_box").show();
$("#browse_hide_areas_box").click(hideAreas);
}
function updateData() {
if (browseMode == "auto") {
@ -547,3 +546,4 @@ function clearStatus() {
$("#browse_status").html("");
$("#browse_status").hide();
}
}

4
app/assets/javascripts/export.js
View file

@ -1,10 +1,10 @@
function startExport(sidebarHtml) {
var vectors;
var box;
var transform;
var markerLayer;
var markerControl;
function startExport(sidebarHtml) {
vectors = new OpenLayers.Layer.Vector("Vector Layer", {
displayInLayerSwitcher: false
});
@ -60,7 +60,6 @@ function startExport(sidebarHtml) {
$("#viewanchor").removeClass("active");
$("#exportanchor").addClass("active");
}
function stopExport() {
$("#viewanchor").addClass("active");
@ -330,3 +329,4 @@ function mapnikSizeChanged() {
validateControls();
}
}