Refactored and added new test

2018-07-26 16:27:28 +01:00 · 2018-07-26 16:27:28 +01:00 · 07480996d7
commit 07480996d7
parent a04b19a9ae
2 changed files with 21 additions and 2 deletions
--- a/app/controllers/traces_controller.rb
+++ b/app/controllers/traces_controller.rb
@ -117,8 +117,12 @@ class TracesController < ApplicationController
        do_create(params[:trace][:gpx_file], params[:trace][:tagstring],
                  params[:trace][:description], params[:trace][:visibility])
      rescue StandardError => ex
-        render :action => "new" and return unless @trace.valid?
-        logger.debug ex
+        if @trace.valid?
+          flash[:error] = t("traces.create.upload_failed")
+          logger.debug ex
+        end
+        render :action => "new"
+        return
      end

      if @trace.id