cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Simplify hide path helper calls

Browse source
This commit is contained in:
Anton Khorev 2024-07-16 17:35:04 +03:00
parent 1f4c298f76
commit 067754b766
1 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

16
test/controllers/api/changeset_comments_controller_test.rb
View file

@ -225,21 +225,21 @@ module Api
comment = create(:changeset_comment) comment = create(:changeset_comment)
assert comment.visible assert comment.visible
post changeset_comment_hide_path(:id => comment) post changeset_comment_hide_path(comment)
assert_response :unauthorized assert_response :unauthorized
assert comment.reload.visible assert comment.reload.visible
auth_header = basic_authorization_header create(:user).email, "test" auth_header = basic_authorization_header create(:user).email, "test"
# not a moderator # not a moderator
post changeset_comment_hide_path(:id => comment), :headers => auth_header post changeset_comment_hide_path(comment), :headers => auth_header
assert_response :forbidden assert_response :forbidden
assert comment.reload.visible assert comment.reload.visible
auth_header = basic_authorization_header create(:moderator_user).email, "test" auth_header = basic_authorization_header create(:moderator_user).email, "test"
# bad comment id # bad comment id
post changeset_comment_hide_path(:id => 999111), :headers => auth_header post changeset_comment_hide_path(999111), :headers => auth_header
assert_response :not_found assert_response :not_found
assert comment.reload.visible assert comment.reload.visible
end end
@ -252,7 +252,7 @@ module Api
auth_header = basic_authorization_header create(:moderator_user).email, "test" auth_header = basic_authorization_header create(:moderator_user).email, "test"
post changeset_comment_hide_path(:id => comment), :headers => auth_header post changeset_comment_hide_path(comment), :headers => auth_header
assert_response :success assert_response :success
assert_not comment.reload.visible assert_not comment.reload.visible
end end
@ -264,21 +264,21 @@ module Api
comment = create(:changeset_comment, :visible => false) comment = create(:changeset_comment, :visible => false)
assert_not comment.visible assert_not comment.visible
post changeset_comment_unhide_path(:id => comment) post changeset_comment_unhide_path(comment)
assert_response :unauthorized assert_response :unauthorized
assert_not comment.reload.visible assert_not comment.reload.visible
auth_header = basic_authorization_header create(:user).email, "test" auth_header = basic_authorization_header create(:user).email, "test"
# not a moderator # not a moderator
post changeset_comment_unhide_path(:id => comment), :headers => auth_header post changeset_comment_unhide_path(comment), :headers => auth_header
assert_response :forbidden assert_response :forbidden
assert_not comment.reload.visible assert_not comment.reload.visible
auth_header = basic_authorization_header create(:moderator_user).email, "test" auth_header = basic_authorization_header create(:moderator_user).email, "test"
# bad comment id # bad comment id
post changeset_comment_unhide_path(:id => 999111), :headers => auth_header post changeset_comment_unhide_path(999111), :headers => auth_header
assert_response :not_found assert_response :not_found
assert_not comment.reload.visible assert_not comment.reload.visible
end end
@ -291,7 +291,7 @@ module Api
auth_header = basic_authorization_header create(:moderator_user).email, "test" auth_header = basic_authorization_header create(:moderator_user).email, "test"
post changeset_comment_unhide_path(:id => comment), :headers => auth_header post changeset_comment_unhide_path(comment), :headers => auth_header
assert_response :success assert_response :success
assert comment.reload.visible assert comment.reload.visible
end end