cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Rename hide_comment and unhide_comment to destroy and restore

Browse source 
This preserves the API endpoints and HTTP methods, which could be changed in the next API version
This commit is contained in:
Andy Allan 2018-11-07 10:51:43 +01:00
parent 4b0d56f7e1
commit 04afeeb32f
3 changed files with 20 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

12
app/controllers/changeset_comments_controller.rb
View file

@ -1,11 +1,11 @@
class ChangesetCommentsController < ApplicationController
before_action :authorize_web, :only => [:index]
before_action :set_locale, :only => [:index]
before_action :authorize, :only => [:create, :hide_comment, :unhide_comment]
before_action :require_moderator, :only => [:hide_comment, :unhide_comment]
before_action :require_allow_write_api, :only => [:create, :hide_comment, :unhide_comment]
before_action :authorize, :only => [:create, :destroy, :restore]
before_action :require_moderator, :only => [:destroy, :restore]
before_action :require_allow_write_api, :only => [:create, :destroy, :restore]
before_action :require_public_data, :only => [:create]
before_action :check_api_writable, :only => [:create, :hide_comment, :unhide_comment]
before_action :check_api_writable, :only => [:create, :destroy, :restore]
before_action :check_api_readable, :except => [:create, :index]
before_action(:only => [:index]) { |c| c.check_database_readable(true) }
around_action :api_call_handle_error, :except => [:index]
@ -46,7 +46,7 @@ class ChangesetCommentsController < ApplicationController
##
# Sets visible flag on comment to false
def hide_comment
def destroy
# Check the arguments are sane
raise OSM::APIBadUserInput, "No id was given" unless params[:id]
@ -65,7 +65,7 @@ class ChangesetCommentsController < ApplicationController
##
# Sets visible flag on comment to true
def unhide_comment
def restore
# Check the arguments are sane
raise OSM::APIBadUserInput, "No id was given" unless params[:id]