Merge branch 'master' into openstreetbugs

app/controllers/changeset_controller.rb

@@ -4,16 +4,17 @@ class ChangesetController < ApplicationController
   layout 'site'
   require 'xml/libxml'
 
-  before_filter :authorize_web, :only => [:list, :list_user, :list_bbox]
-  before_filter :set_locale, :only => [:list, :list_user, :list_bbox]
+  before_filter :authorize_web, :only => [:list]
+  before_filter :set_locale, :only => [:list]
   before_filter :authorize, :only => [:create, :update, :delete, :upload, :include, :close]
   before_filter :require_allow_write_api, :only => [:create, :update, :delete, :upload, :include, :close]
   before_filter :require_public_data, :only => [:create, :update, :delete, :upload, :include, :close]
   before_filter :check_api_writable, :only => [:create, :update, :delete, :upload, :include]
-  before_filter :check_api_readable, :except => [:create, :update, :delete, :upload, :download, :query]
+  before_filter :check_api_readable, :except => [:create, :update, :delete, :upload, :download, :query, :list]
+  before_filter(:only => [:list]) { |c| c.check_database_readable(true) }
   after_filter :compress_output
-  around_filter :api_call_handle_error, :except => [:list, :list_user, :list_bbox]
-  around_filter :web_timeout, :only => [:list, :list_user, :list_bbox]
+  around_filter :api_call_handle_error, :except => [:list]
+  around_filter :web_timeout, :only => [:list]
 
   filter_parameter_logging "<osmChange version"
 

app/helpers/application_helper.rb

@@ -44,9 +44,16 @@ module ApplicationHelper
     zoom = zoom || 14
     language = language || request.user_preferred_languages.join(',')
     url = "http://nominatim.openstreetmap.org/reverse?lat=#{lat}&lon=#{lon}&zoom=#{zoom}&accept-language=#{language}"
-    response = REXML::Document.new(Net::HTTP.get(URI.parse(url)))
 
-    if result = response.get_text("reversegeocode/result")
+    begin
+      Timeout::timeout(4) do
+        response = REXML::Document.new(Net::HTTP.get(URI.parse(url)))
+      end
+    rescue Exception
+      response = nil
+    end
+
+    if response and result = response.get_text("reversegeocode/result")
       result.to_s
     else
       "#{number_with_precision(lat, :precision => 3)}, #{number_with_precision(lon, :precision => 3)}"

app/helpers/browse_helper.rb

@@ -56,9 +56,15 @@ private
   def wiki_link(type, lookup)
     locale = I18n.locale.to_s
 
-    if page = WIKI_PAGES[locale][type][lookup] rescue nil
+    # update-wiki-pages does s/ /_/g on keys before saving them, we
+    # have to replace spaces with underscore so we'll link
+    # e.g. `source=Isle of Man Government aerial imagery (2001)' to
+    # the correct page.
+    lookup_us = lookup.tr(" ", "_")
+
+    if page = WIKI_PAGES[locale][type][lookup_us] rescue nil
       url = "http://wiki.openstreetmap.org/wiki/#{page}?uselang=#{locale}"
-    elsif page = WIKI_PAGES["en"][type][lookup] rescue nil
+    elsif page = WIKI_PAGES["en"][type][lookup_us] rescue nil
       url = "http://wiki.openstreetmap.org/wiki/#{page}?uselang=#{locale}"
     end
 

app/models/notifier.rb

@@ -48,7 +48,7 @@ class Notifier < ActionMailer::Base
   def message_notification(message)
     common_headers message.recipient
     from_header message.sender.display_name, "m", message.id, message.digest
-    subject I18n.t('notifier.message_notification.subject', :user => message.sender.display_name, :locale => locale)
+    subject message.title
     body :to_user => message.recipient.display_name,
          :from_user => message.sender.display_name,
          :body => message.body,

app/views/browse/_node_details.html.erb

@@ -1,4 +1,4 @@
-<table>
+<table id="<%= node_details.version %>">
 
   <%= render :partial => "common_details", :object => node_details %>
 

app/views/browse/_relation_details.html.erb

@@ -1,4 +1,4 @@
-<table>
+<table id="<%= relation_details.version %>">
 
   <%= render :partial => "common_details", :object => relation_details %>
 

app/views/browse/_way_details.html.erb

@@ -1,4 +1,4 @@
-<table>
+<table id="<%= way_details.version %>">
 
   <%= render :partial => "common_details", :object => way_details %>
 

app/views/diary_entry/_diary_entry.html.erb

@@ -1,5 +1,7 @@
 <b><%= link_to h(diary_entry.title), :action => 'view', :display_name => diary_entry.user.display_name, :id => diary_entry.id %></b><br />
+<div xml:lang="<%= diary_entry.language_code %>" lang="<%= diary_entry.language_code %>">
 <%= htmlize(diary_entry.body) %>
+</div>
 <% if diary_entry.latitude and diary_entry.longitude %>
 <%= render :partial => "location", :object => diary_entry %>
 <br />