cst1/kpsul
1
0
Fork 0
forked from DGNum/gestioCOF
Code Pull requests Activity

Don't crash on LDAP errors

Browse source
This commit is contained in:
Martin Pépin 2020-06-28 23:48:20 +02:00
parent 56f1edebe3
commit de1bba3695
No known key found for this signature in database
GPG key ID: E7520278B1774448
1 changed files with 18 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
shared/views/autocomplete.py
View file

@ -1,3 +1,4 @@
import logging
from collections import namedtuple from collections import namedtuple
from dal import autocomplete from dal import autocomplete
@ -12,6 +13,9 @@ else:
ldap = None ldap = None
django_logger = logging.getLogger("django.request")
class SearchUnit: class SearchUnit:
"""Base class for all the search utilities. """Base class for all the search utilities.
@ -128,17 +132,21 @@ class LDAPSearch(SearchUnit):
if ldap is None or query == "(&)": if ldap is None or query == "(&)":
return [] return []
ldap_obj = ldap.initialize(self.ldap_server_url) try:
res = ldap_obj.search_s( ldap_obj = ldap.initialize(self.ldap_server_url)
self.domain_component, ldap.SCOPE_SUBTREE, query, self.search_fields res = ldap_obj.search_s(
) self.domain_component, ldap.SCOPE_SUBTREE, query, self.search_fields
return [
Clipper(
clipper=attrs["uid"][0].decode("utf-8"),
fullname=attrs["cn"][0].decode("utf-8"),
) )
for (_, attrs) in res return [
] Clipper(
clipper=attrs["uid"][0].decode("utf-8"),
fullname=attrs["cn"][0].decode("utf-8"),
)
for (_, attrs) in res
]
except ldap.LDAPError as err:
django_logger.error("An LDAP error occurred", exc_info=err)
return []
# --- # ---