cst1/kpsul
1
0
Fork 0
forked from DGNum/gestioCOF
Code Pull requests Activity

Handle errors when sending welcome emails during member registraton

Browse source
This commit is contained in:
Martin Pépin 2019-02-04 22:09:57 +01:00 committed by Ludovic Stephan
parent 1cf333f0fc
commit 9f23f85b87
1 changed files with 21 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
gestioncof/views.py
View file

@ -1,5 +1,6 @@
import uuid import uuid
from datetime import timedelta from datetime import timedelta
from smtplib import SMTPRecipientsRefused
import unicodecsv import unicodecsv
from custommail.shortcuts import send_custom_mail from custommail.shortcuts import send_custom_mail
@ -445,6 +446,25 @@ def registration_form2(request, login_clipper=None, username=None, fullname=None
) )
def notify_new_member(request, member: User):
if not member.email:
messages.warning(
request,
"GestioCOF n'a pas d'adresse mail pour {}, ".format(member)
+ "aucun email de bienvenue n'a été envoyé",
)
# Try to send a welcome email and report SMTP errors
try:
send_custom_mail(
"welcome", "cof@ens.fr", [member.email], context={"member": member}
)
except SMTPRecipientsRefused:
messages.error(
request,
"Error lors de l'envoi de l'email de bienvenue à {}".format(member.email),
)
@buro_required @buro_required
def registration(request): def registration(request):
if request.POST: if request.POST:
@ -494,12 +514,7 @@ def registration(request):
# Enregistrement du profil # Enregistrement du profil
profile = profile_form.save() profile = profile_form.save()
if profile.is_cof and not was_cof: if profile.is_cof and not was_cof:
send_custom_mail( notify_new_member(request, member)
"welcome",
"cof@ens.fr",
[member.email],
context={"member": member},
)
# Enregistrement des inscriptions aux événements # Enregistrement des inscriptions aux événements
for form in event_formset: for form in event_formset:
if "status" not in form.cleaned_data: if "status" not in form.cleaned_data: