DGNum/ubus
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ubusd: don't check ACL when object is NULL

Browse source 
If there are any ACLs present other than global wildcard "*", the AVL
tree comparator will compare ACL key to object name. However, object
name can be NULL in cases where ACL check is done on call to internal
ubus objects (e.g. ubus monitor).

With this change we skip checking ACLs on such NULL objects.

Signed-off-by: Denis Osvald <denis.osvald@sartura.hr>
This commit is contained in:
Denis Osvald 2016-08-25 13:54:52 +02:00 committed by Felix Fietkau
parent 686c05d738
commit d6bb4f1a1d
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ubusd_acl.c
View file

@ -101,7 +101,7 @@ ubusd_acl_check(struct ubus_client *cl, const char *obj,
struct blob_attr *cur; struct blob_attr *cur;
int rem; int rem;
if (!cl->uid) if (!cl->uid || !obj)
return 0; return 0;
acl = avl_find_ge_element(&ubusd_acls, obj, acl, avl); acl = avl_find_ge_element(&ubusd_acls, obj, acl, avl);