DGNum/ubus
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ubusd: fix issue caused by an implicit cast

Browse source 
An -1 returned by ubus_msg_writev() will be interpreted as
UINT_MAX during a check to see how much data had could be
written on the socket.

Because sizeof() will return size_t it will promote the
comparsion to unsigned

Signed-off-by: Mihai Richard <mihairichard@live.com>
This commit is contained in:
Mihai Richard 2017-01-19 12:51:04 +00:00 committed by Felix Fietkau
parent ad5333a73b
commit 97ac89f972
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
ubusd.c
View file

@ -148,12 +148,13 @@ void ubus_msg_send(struct ubus_client *cl, struct ubus_msg_buf *ub, bool free)
if (!cl->tx_queue[cl->txq_cur]) {
written = ubus_msg_writev(cl->sock.fd, ub, 0);
if (written >= ub->len + sizeof(ub->hdr))
goto out;
if (written < 0)
written = 0;
if (written >= ub->len + sizeof(ub->hdr))
goto out;
cl->txq_ofs = written;
/* get an event once we can write to the socket again */