libubus: refactor code, move request handling to libubus-req.c

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
This commit is contained in:
Felix Fietkau 2012-12-14 14:13:27 +01:00
parent 7cd33a8e3a
commit 2cae3fb422
4 changed files with 312 additions and 279 deletions

View file

@ -12,7 +12,7 @@ IF(APPLE)
LINK_DIRECTORIES(/opt/local/lib)
ENDIF()
ADD_LIBRARY(ubus SHARED libubus.c libubus-io.c libubus-obj.c libubus-sub.c)
ADD_LIBRARY(ubus SHARED libubus.c libubus-io.c libubus-obj.c libubus-sub.c libubus-req.c)
TARGET_LINK_LIBRARIES(ubus ubox)
ADD_EXECUTABLE(ubusd ubusd.c ubusd_id.c ubusd_obj.c ubusd_proto.c ubusd_event.c)

View file

@ -17,6 +17,7 @@
#define __hidden __attribute__((visibility ("hidden")))
extern struct blob_buf b;
extern const struct ubus_method watch_method;
struct blob_attr **ubus_parse_msg(struct blob_attr *msg);
void ubus_handle_data(struct uloop_fd *u, unsigned int events);
@ -26,6 +27,7 @@ void ubus_process_msg(struct ubus_context *ctx, struct ubus_msghdr *hdr);
int __hidden ubus_start_request(struct ubus_context *ctx, struct ubus_request *req,
struct blob_attr *msg, int cmd, uint32_t peer);
void ubus_process_obj_msg(struct ubus_context*ctx, struct ubus_msghdr *hdr);
extern const struct ubus_method watch_method;
void ubus_process_req_msg(struct ubus_context *ctx, struct ubus_msghdr *hdr);
void ubus_process_pending_msg(struct ubus_context *ctx);
#endif

291
libubus-req.c Normal file
View file

@ -0,0 +1,291 @@
/*
* Copyright (C) 2011-2012 Felix Fietkau <nbd@openwrt.org>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU Lesser General Public License version 2.1
* as published by the Free Software Foundation
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*/
#include "libubus.h"
#include "libubus-internal.h"
struct ubus_pending_data {
struct list_head list;
int type;
struct blob_attr data[];
};
static void req_data_cb(struct ubus_request *req, int type, struct blob_attr *data)
{
struct blob_attr **attr;
if (req->raw_data_cb)
req->raw_data_cb(req, type, data);
if (!req->data_cb)
return;
attr = ubus_parse_msg(data);
req->data_cb(req, type, attr[UBUS_ATTR_DATA]);
}
static void __ubus_process_req_data(struct ubus_request *req)
{
struct ubus_pending_data *data;
while (!list_empty(&req->pending)) {
data = list_first_entry(&req->pending,
struct ubus_pending_data, list);
list_del(&data->list);
if (!req->cancelled)
req_data_cb(req, data->type, data->data);
free(data);
}
}
void ubus_abort_request(struct ubus_context *ctx, struct ubus_request *req)
{
if (!list_empty(&req->list))
return;
req->cancelled = true;
__ubus_process_req_data(req);
list_del_init(&req->list);
}
void ubus_complete_request_async(struct ubus_context *ctx, struct ubus_request *req)
{
if (!list_empty(&req->list))
return;
list_add(&req->list, &ctx->requests);
}
static void ubus_sync_req_cb(struct ubus_request *req, int ret)
{
req->status_msg = true;
req->status_code = ret;
uloop_end();
}
struct ubus_sync_req_cb {
struct uloop_timeout timeout;
struct ubus_request *req;
};
static void ubus_sync_req_timeout_cb(struct uloop_timeout *timeout)
{
struct ubus_sync_req_cb *cb;
cb = container_of(timeout, struct ubus_sync_req_cb, timeout);
ubus_sync_req_cb(cb->req, UBUS_STATUS_TIMEOUT);
}
int ubus_complete_request(struct ubus_context *ctx, struct ubus_request *req,
int timeout)
{
struct ubus_sync_req_cb cb;
ubus_complete_handler_t complete_cb = req->complete_cb;
bool registered = ctx->sock.registered;
int status = UBUS_STATUS_NO_DATA;
if (!registered) {
uloop_init();
ubus_add_uloop(ctx);
}
if (timeout) {
memset(&cb, 0, sizeof(cb));
cb.req = req;
cb.timeout.cb = ubus_sync_req_timeout_cb;
uloop_timeout_set(&cb.timeout, timeout);
}
ubus_complete_request_async(ctx, req);
req->complete_cb = ubus_sync_req_cb;
ctx->stack_depth++;
while (!req->status_msg) {
bool cancelled = uloop_cancelled;
uloop_cancelled = false;
uloop_run();
uloop_cancelled = cancelled;
}
ctx->stack_depth--;
if (timeout)
uloop_timeout_cancel(&cb.timeout);
if (req->status_msg)
status = req->status_code;
req->complete_cb = complete_cb;
if (req->complete_cb)
req->complete_cb(req, status);
if (!registered)
uloop_fd_delete(&ctx->sock);
if (!ctx->stack_depth)
ubus_process_pending_msg(ctx);
return status;
}
void ubus_complete_deferred_request(struct ubus_context *ctx, struct ubus_request_data *req, int ret)
{
blob_buf_init(&b, 0);
blob_put_int32(&b, UBUS_ATTR_STATUS, ret);
blob_put_int32(&b, UBUS_ATTR_OBJID, req->object);
ubus_send_msg(ctx, req->seq, b.head, UBUS_MSG_STATUS, req->peer);
}
int ubus_send_reply(struct ubus_context *ctx, struct ubus_request_data *req,
struct blob_attr *msg)
{
int ret;
blob_buf_init(&b, 0);
blob_put_int32(&b, UBUS_ATTR_OBJID, req->object);
blob_put(&b, UBUS_ATTR_DATA, blob_data(msg), blob_len(msg));
ret = ubus_send_msg(ctx, req->seq, b.head, UBUS_MSG_DATA, req->peer);
if (ret < 0)
return UBUS_STATUS_NO_DATA;
return 0;
}
int ubus_invoke_async(struct ubus_context *ctx, uint32_t obj, const char *method,
struct blob_attr *msg, struct ubus_request *req)
{
blob_buf_init(&b, 0);
blob_put_int32(&b, UBUS_ATTR_OBJID, obj);
blob_put_string(&b, UBUS_ATTR_METHOD, method);
if (msg)
blob_put(&b, UBUS_ATTR_DATA, blob_data(msg), blob_len(msg));
if (ubus_start_request(ctx, req, b.head, UBUS_MSG_INVOKE, obj) < 0)
return UBUS_STATUS_INVALID_ARGUMENT;
return 0;
}
int ubus_invoke(struct ubus_context *ctx, uint32_t obj, const char *method,
struct blob_attr *msg, ubus_data_handler_t cb, void *priv,
int timeout)
{
struct ubus_request req;
ubus_invoke_async(ctx, obj, method, msg, &req);
req.data_cb = cb;
req.priv = priv;
return ubus_complete_request(ctx, &req, timeout);
}
static void ubus_req_complete_cb(struct ubus_request *req)
{
ubus_complete_handler_t cb = req->complete_cb;
if (!cb)
return;
req->complete_cb = NULL;
cb(req, req->status_code);
}
static bool ubus_get_status(struct ubus_msghdr *hdr, int *ret)
{
struct blob_attr **attrbuf = ubus_parse_msg(hdr->data);
if (!attrbuf[UBUS_ATTR_STATUS])
return false;
*ret = blob_get_u32(attrbuf[UBUS_ATTR_STATUS]);
return true;
}
static int
ubus_process_req_status(struct ubus_request *req, struct ubus_msghdr *hdr)
{
int ret = UBUS_STATUS_INVALID_ARGUMENT;
if (!list_empty(&req->list))
list_del_init(&req->list);
ubus_get_status(hdr, &ret);
req->peer = hdr->peer;
req->status_msg = true;
req->status_code = ret;
if (!req->blocked)
ubus_req_complete_cb(req);
return ret;
}
static void
ubus_process_req_data(struct ubus_request *req, struct ubus_msghdr *hdr)
{
struct ubus_pending_data *data;
int len;
if (!req->blocked) {
req->blocked = true;
req_data_cb(req, hdr->type, hdr->data);
__ubus_process_req_data(req);
req->blocked = false;
if (req->status_msg)
ubus_req_complete_cb(req);
return;
}
len = blob_raw_len(hdr->data);
data = calloc(1, sizeof(*data) + len);
if (!data)
return;
data->type = hdr->type;
memcpy(data->data, hdr->data, len);
list_add(&data->list, &req->pending);
}
static struct ubus_request *
ubus_find_request(struct ubus_context *ctx, uint32_t seq, uint32_t peer)
{
struct ubus_request *req;
list_for_each_entry(req, &ctx->requests, list) {
if (seq != req->seq || peer != req->peer)
continue;
return req;
}
return NULL;
}
void __hidden ubus_process_req_msg(struct ubus_context *ctx, struct ubus_msghdr *hdr)
{
struct ubus_request *req;
switch(hdr->type) {
case UBUS_MSG_STATUS:
req = ubus_find_request(ctx, hdr->seq, hdr->peer);
if (!req)
break;
ubus_process_req_status(req, hdr);
break;
case UBUS_MSG_DATA:
req = ubus_find_request(ctx, hdr->seq, hdr->peer);
if (req && (req->data_cb || req->raw_data_cb))
ubus_process_req_data(req, hdr);
break;
}
}

294
libubus.c
View file

@ -38,19 +38,11 @@ const char *__ubus_strerror[__UBUS_STATUS_LAST] = {
struct blob_buf b __hidden = {};
struct ubus_pending_data {
struct list_head list;
int type;
struct blob_attr data[];
};
struct ubus_pending_invoke {
struct ubus_pending_msg {
struct list_head list;
struct ubus_msghdr hdr;
};
static void ubus_process_pending_invoke(struct ubus_context *ctx);
static int ubus_cmp_id(const void *k1, const void *k2, void *ptr)
{
const uint32_t *id1 = k1, *id2 = k2;
@ -78,164 +70,45 @@ out:
return err;
}
static bool ubus_get_status(struct ubus_msghdr *hdr, int *ret)
static void
ubus_queue_msg(struct ubus_context *ctx, struct ubus_msghdr *hdr)
{
struct blob_attr **attrbuf = ubus_parse_msg(hdr->data);
struct ubus_pending_msg *pending;
if (!attrbuf[UBUS_ATTR_STATUS])
return false;
*ret = blob_get_u32(attrbuf[UBUS_ATTR_STATUS]);
return true;
}
static void req_data_cb(struct ubus_request *req, int type, struct blob_attr *data)
{
struct blob_attr **attr;
if (req->raw_data_cb)
req->raw_data_cb(req, type, data);
if (!req->data_cb)
pending = calloc(1, sizeof(*pending) + blob_raw_len(hdr->data));
if (!pending)
return;
attr = ubus_parse_msg(data);
req->data_cb(req, type, attr[UBUS_ATTR_DATA]);
memcpy(&pending->hdr, hdr, sizeof(*hdr) + blob_raw_len(hdr->data));
list_add(&pending->list, &ctx->pending);
}
static void ubus_process_req_data(struct ubus_request *req)
void __hidden
ubus_process_msg(struct ubus_context *ctx, struct ubus_msghdr *hdr)
{
struct ubus_pending_data *data;
while (!list_empty(&req->pending)) {
data = list_first_entry(&req->pending,
struct ubus_pending_data, list);
list_del(&data->list);
if (!req->cancelled)
req_data_cb(req, data->type, data->data);
free(data);
}
}
static void ubus_req_complete_cb(struct ubus_request *req)
{
ubus_complete_handler_t cb = req->complete_cb;
if (!cb)
return;
req->complete_cb = NULL;
cb(req, req->status_code);
}
static int ubus_process_req_status(struct ubus_request *req, struct ubus_msghdr *hdr)
{
int ret = UBUS_STATUS_INVALID_ARGUMENT;
if (!list_empty(&req->list))
list_del_init(&req->list);
ubus_get_status(hdr, &ret);
req->peer = hdr->peer;
req->status_msg = true;
req->status_code = ret;
if (!req->blocked)
ubus_req_complete_cb(req);
return ret;
}
static void ubus_req_data(struct ubus_request *req, struct ubus_msghdr *hdr)
{
struct ubus_pending_data *data;
int len;
if (!req->blocked) {
req->blocked = true;
req_data_cb(req, hdr->type, hdr->data);
ubus_process_req_data(req);
req->blocked = false;
if (req->status_msg)
ubus_req_complete_cb(req);
return;
}
len = blob_raw_len(hdr->data);
data = calloc(1, sizeof(*data) + len);
if (!data)
return;
data->type = hdr->type;
memcpy(data->data, hdr->data, len);
list_add(&data->list, &req->pending);
}
static struct ubus_request *ubus_find_request(struct ubus_context *ctx, uint32_t seq, uint32_t peer)
{
struct ubus_request *req;
list_for_each_entry(req, &ctx->requests, list) {
if (seq != req->seq || peer != req->peer)
continue;
return req;
}
return NULL;
}
void ubus_complete_deferred_request(struct ubus_context *ctx, struct ubus_request_data *req, int ret)
{
blob_buf_init(&b, 0);
blob_put_int32(&b, UBUS_ATTR_STATUS, ret);
blob_put_int32(&b, UBUS_ATTR_OBJID, req->object);
ubus_send_msg(ctx, req->seq, b.head, UBUS_MSG_STATUS, req->peer);
}
void __hidden ubus_process_msg(struct ubus_context *ctx, struct ubus_msghdr *hdr)
{
struct ubus_pending_invoke *pending;
struct ubus_request *req;
switch(hdr->type) {
case UBUS_MSG_STATUS:
req = ubus_find_request(ctx, hdr->seq, hdr->peer);
if (!req)
break;
ubus_process_req_status(req, hdr);
break;
case UBUS_MSG_DATA:
req = ubus_find_request(ctx, hdr->seq, hdr->peer);
if (req && (req->data_cb || req->raw_data_cb))
ubus_req_data(req, hdr);
ubus_process_req_msg(ctx, hdr);
break;
case UBUS_MSG_INVOKE:
case UBUS_MSG_UNSUBSCRIBE:
case UBUS_MSG_NOTIFY:
if (ctx->stack_depth > 2) {
pending = calloc(1, sizeof(*pending) +
blob_raw_len(hdr->data));
if (!pending)
return;
memcpy(&pending->hdr, hdr, sizeof(*hdr) +
blob_raw_len(hdr->data));
list_add(&pending->list, &ctx->pending);
} else {
ubus_process_obj_msg(ctx, hdr);
ubus_queue_msg(ctx, hdr);
break;
}
ubus_process_obj_msg(ctx, hdr);
break;
}
}
static void ubus_process_pending_invoke(struct ubus_context *ctx)
void __hidden ubus_process_pending_msg(struct ubus_context *ctx)
{
struct ubus_pending_invoke *pending, *tmp;
struct ubus_pending_msg *pending, *tmp;
list_for_each_entry_safe(pending, tmp, &ctx->pending, list) {
list_del(&pending->list);
@ -246,95 +119,6 @@ static void ubus_process_pending_invoke(struct ubus_context *ctx)
}
}
void ubus_abort_request(struct ubus_context *ctx, struct ubus_request *req)
{
if (!list_empty(&req->list))
return;
req->cancelled = true;
ubus_process_req_data(req);
list_del_init(&req->list);
}
void ubus_complete_request_async(struct ubus_context *ctx, struct ubus_request *req)
{
if (!list_empty(&req->list))
return;
list_add(&req->list, &ctx->requests);
}
static void ubus_sync_req_cb(struct ubus_request *req, int ret)
{
req->status_msg = true;
req->status_code = ret;
uloop_end();
}
struct ubus_sync_req_cb {
struct uloop_timeout timeout;
struct ubus_request *req;
};
static void ubus_sync_req_timeout_cb(struct uloop_timeout *timeout)
{
struct ubus_sync_req_cb *cb;
cb = container_of(timeout, struct ubus_sync_req_cb, timeout);
ubus_sync_req_cb(cb->req, UBUS_STATUS_TIMEOUT);
}
int ubus_complete_request(struct ubus_context *ctx, struct ubus_request *req,
int timeout)
{
struct ubus_sync_req_cb cb;
ubus_complete_handler_t complete_cb = req->complete_cb;
bool registered = ctx->sock.registered;
int status = UBUS_STATUS_NO_DATA;
if (!registered) {
uloop_init();
ubus_add_uloop(ctx);
}
if (timeout) {
memset(&cb, 0, sizeof(cb));
cb.req = req;
cb.timeout.cb = ubus_sync_req_timeout_cb;
uloop_timeout_set(&cb.timeout, timeout);
}
ubus_complete_request_async(ctx, req);
req->complete_cb = ubus_sync_req_cb;
ctx->stack_depth++;
while (!req->status_msg) {
bool cancelled = uloop_cancelled;
uloop_cancelled = false;
uloop_run();
uloop_cancelled = cancelled;
}
ctx->stack_depth--;
if (timeout)
uloop_timeout_cancel(&cb.timeout);
if (req->status_msg)
status = req->status_code;
req->complete_cb = complete_cb;
if (req->complete_cb)
req->complete_cb(req, status);
if (!registered)
uloop_fd_delete(&ctx->sock);
if (!ctx->stack_depth)
ubus_process_pending_invoke(ctx);
return status;
}
struct ubus_lookup_request {
struct ubus_request req;
ubus_lookup_handler_t cb;
@ -425,50 +209,6 @@ int ubus_lookup_id(struct ubus_context *ctx, const char *path, uint32_t *id)
return ubus_complete_request(ctx, &req, 0);
}
int ubus_send_reply(struct ubus_context *ctx, struct ubus_request_data *req,
struct blob_attr *msg)
{
int ret;
blob_buf_init(&b, 0);
blob_put_int32(&b, UBUS_ATTR_OBJID, req->object);
blob_put(&b, UBUS_ATTR_DATA, blob_data(msg), blob_len(msg));
ret = ubus_send_msg(ctx, req->seq, b.head, UBUS_MSG_DATA, req->peer);
if (ret < 0)
return UBUS_STATUS_NO_DATA;
return 0;
}
int ubus_invoke_async(struct ubus_context *ctx, uint32_t obj, const char *method,
struct blob_attr *msg, struct ubus_request *req)
{
blob_buf_init(&b, 0);
blob_put_int32(&b, UBUS_ATTR_OBJID, obj);
blob_put_string(&b, UBUS_ATTR_METHOD, method);
if (msg)
blob_put(&b, UBUS_ATTR_DATA, blob_data(msg), blob_len(msg));
if (ubus_start_request(ctx, req, b.head, UBUS_MSG_INVOKE, obj) < 0)
return UBUS_STATUS_INVALID_ARGUMENT;
return 0;
}
int ubus_invoke(struct ubus_context *ctx, uint32_t obj, const char *method,
struct blob_attr *msg, ubus_data_handler_t cb, void *priv,
int timeout)
{
struct ubus_request req;
ubus_invoke_async(ctx, obj, method, msg, &req);
req.data_cb = cb;
req.priv = priv;
return ubus_complete_request(ctx, &req, timeout);
}
static int ubus_event_cb(struct ubus_context *ctx, struct ubus_object *obj,
struct ubus_request_data *req,
const char *method, struct blob_attr *msg)