DGNum/ubus
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ubusd_monitor: alloc & free the buffer outside of the loop

Browse source 
Should save a few cycles, since the data that's
being changed is only the seq number.
And the `ub` is always created as shared.

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
This commit is contained in:
Alexandru Ardelean 2017-07-05 16:21:47 +03:00 committed by Felix Fietkau
parent be146ad2bc
commit 27d712d394
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
ubusd_monitor.c
View file

@ -72,13 +72,15 @@ ubusd_monitor_message(struct ubus_client *cl, struct ubus_msg_buf *ub, bool send
blob_put_int8(&mb, UBUS_MONITOR_SEND, send); blob_put_int8(&mb, UBUS_MONITOR_SEND, send);
blob_put(&mb, UBUS_MONITOR_DATA, blob_data(ub->data), blob_len(ub->data)); blob_put(&mb, UBUS_MONITOR_DATA, blob_data(ub->data), blob_len(ub->data));
list_for_each_entry(m, &monitors, list) {
ub = ubus_msg_new(mb.head, blob_raw_len(mb.head), true); ub = ubus_msg_new(mb.head, blob_raw_len(mb.head), true);
ub->hdr.type = UBUS_MSG_MONITOR; ub->hdr.type = UBUS_MSG_MONITOR;
list_for_each_entry(m, &monitors, list) {
ub->hdr.seq = ++m->seq; ub->hdr.seq = ++m->seq;
ubus_msg_send(m->cl, ub); ubus_msg_send(m->cl, ub);
ubus_msg_free(ub);
} }
ubus_msg_free(ub);
} }
static int static int