DGNum/rust-irc
6
0
Fork 0
Code Issues 1 Pull requests 3 Projects Releases Packages Wiki Activity Actions

Added some contributor guidelines based on the Puppet ones.

Browse source
This commit is contained in:
Aaron Weiss 2018-02-14 14:11:43 +01:00
parent cabe0919c8
commit 6f705989fc
No known key found for this signature in database
GPG key ID: 047D32DF25DC22EF
2 changed files with 48 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

46
CONTRIBUTING.md Normal file
View file

@ -0,0 +1,46 @@
# How to contribute
Your contributions are essential for making the irc crate the best piece of software it could
possibly be! We welcome contributions from programmers of all skill levels, and are happy to provide
mentorship for new contributors working on bug fixes. To make the onboarding process as painless as
possible for everyone, there are a few guidelines that we need contributors to follow.
## Getting Started
* Make sure you have a [GitHub account](https://github.com/signup/free).
* Fork the repository on GitHub.
## Making Changes
* Create a topic branch from where you want to base your work.
* This is almost always the develop branch.
* Only target stable or a maintainer's feature branch if you are certain your fix must be on that
branch.
* To quickly create a topic branch based on develop, run `git checkout -b
fix/develop/my_contribution develop`. Please avoid working directly on the
`stable` branch, and keep direct work on `develop` only to small changes.
* Make commits of logical and atomic units.
* Check for unnecessary whitespace with `git diff --check` before committing.
* Make sure you have added the necessary tests for your changes.
* Run _all_ the tests to assure nothing else was accidentally broken using `cargo test`. You can
also run `cargo test --no-default-features`, but this is generally not relevant and will be
handled by our continuous integration tools.
* Some tests related to configurations will fail if you don't run the `mktestconfig.sh` script.
## Submitting Changes
* Push your changes to a topic branch in your fork of the repository.
* Submit a pull request to the `aatxe/irc` repository.
* Await maintainer feedback and continuous integration results.
* We make an effort to triage quickly, but patience is appreciated!
## Additional Resources
* [Code of Conduct](https://github.com/aatxe/irc/blob/develop/CODE_OF_CONDUCT.md)
* [the irc crate docs](https://docs.rs/irc)
* #irc IRC channel on irc.mozilla.org
## Credits
These contributing guidelines were inspired by the
[Puppet contributor guidelines](https://github.com/puppetlabs/puppet/blob/master/CONTRIBUTING.md).

3
README.md
View file

@ -175,7 +175,8 @@ the irc crate is an free, open source library that relies on contributions from
Aaron Weiss ([@aatxe][awe]) and Peter Atashian ([@retep998][bun]), as well as the broader Rust
community. It's licensed under the Mozilla Public License 2.0 whose text can be found in
`LICENSE.md`. To foster an inclusive community around the irc crate, we have adopted a Code of
Conduct whose text can be found in `CODE_OF_CONDUCT.md`.
Conduct whose text can be found in `CODE_OF_CONDUCT.md`. You can find details about how to
contribute in `CONTRIBUTING.md`.
[awe]: https://github.com/aatxe/
[bun]: https://github.com/retep998/